Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct grammar; and remove redundant comment #33968

Merged
merged 1 commit into from
May 31, 2016
Merged

Correct grammar; and remove redundant comment #33968

merged 1 commit into from
May 31, 2016

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@srinivasreddy
Copy link
Contributor Author

r? @Manishearth

@rust-highfive rust-highfive assigned Manishearth and unassigned aturon May 30, 2016
@srinivasreddy srinivasreddy deleted the slice.rs branch May 30, 2016 17:10
@srinivasreddy srinivasreddy restored the slice.rs branch May 30, 2016 17:11
@srinivasreddy srinivasreddy reopened this May 30, 2016
@Manishearth
Copy link
Member

btw, you don't have to r? every PR at me, it's better to just leave the randomly-assigned assignee as-is unless there's a reason to assign me 😄

Also, git push -f can update branches without needing deletes.

@@ -622,7 +621,7 @@ impl<T> ops::Index<ops::RangeFrom<usize>> for [T] {

/// Implements slicing with syntax `&self[..]`.
///
/// Returns a slice of the whole slice. This operation can not panic.
/// Returns a slice of the whole slice. This operation cannot panic.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a grammar fix, both are correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Manishearth
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 30, 2016

📌 Commit 87bc04f has been approved by Manishearth

@bors
Copy link
Contributor

bors commented May 30, 2016

⌛ Testing commit 87bc04f with merge a967611...

bors added a commit that referenced this pull request May 30, 2016
Correct grammar; and remove redundant comment
@bors bors merged commit 87bc04f into rust-lang:master May 31, 2016
@srinivasreddy srinivasreddy deleted the slice.rs branch May 31, 2016 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants