Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: Fix ICE and extra diagnostics happening when unresolved imports are used in patterns #34963

Merged
merged 1 commit into from
Jul 28, 2016
Merged

resolve: Fix ICE and extra diagnostics happening when unresolved imports are used in patterns #34963

merged 1 commit into from
Jul 28, 2016
+29 −2

Conversation

petrochenkov
Copy link
Contributor

Closes #34933

r? @jseyfried

@jseyfried
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 21, 2016

📌 Commit d7a968e has been approved by jseyfried

@bors
Copy link
Contributor

bors commented Jul 24, 2016

⌛ Testing commit d7a968e with merge d7a0706...

@bors
Copy link
Contributor

bors commented Jul 24, 2016

💔 Test failed - auto-win-msvc-64-opt

@petrochenkov
Copy link
Contributor Author

Spurious failure.

@jseyfried
Copy link
Contributor

@bors retry

@bors
Copy link
Contributor

bors commented Jul 25, 2016

⌛ Testing commit d7a968e with merge f8bf284...

@bors
Copy link
Contributor

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Jul 24, 2016 at 10:51 PM, bors [email protected] wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1926

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34963 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95LkvDBKUuN8VARarhgRx-JwQulFSks5qZE7TgaJpZM4JSGYt
.

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Jul 25, 2016

⌛ Testing commit d7a968e with merge 3121221...

@bors
Copy link
Contributor

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Jul 25, 2016 at 3:06 PM, bors [email protected] wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5072

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34963 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95MePtsnyvQ_ehZECRpdkEPOK6pjwks5qZTOCgaJpZM4JSGYt
.

@bors
Copy link
Contributor

bors commented Jul 26, 2016

⌛ Testing commit d7a968e with merge 85ae467...

@bors
Copy link
Contributor

bors commented Jul 26, 2016

💔 Test failed - auto-win-msvc-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Jul 26, 2016 at 3:31 AM, bors [email protected] wrote:

💔 Test failed - auto-win-msvc-64-opt
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/5072

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34963 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95A6wUWoE-NciOX2dgWHswe0KSL3Cks5qZeIWgaJpZM4JSGYt
.

@jseyfried jseyfried mentioned this pull request Jul 26, 2016
Closed
@Manishearth Manishearth mentioned this pull request Jul 28, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 28, 2016
@Manishearth
Rollup merge of rust-lang#34963 - petrochenkov:useerr, r=jseyfried
43bcada 
resolve: Fix ICE and extra diagnostics happening when unresolved imports are used in patterns

Closes rust-lang#34933

r? @jseyfried
bors added a commit that referenced this pull request Jul 28, 2016
@bors
Auto merge of #35086 - Manishearth:rollup, r=Manishearth
748ecb1 
Rollup of 7 pull requests

- Successful merges: #34951, #34963, #34969, #35013, #35037, #35040, #35058
- Failed merges:
@bors bors merged commit d7a968e into rust-lang:master Jul 28, 2016
@petrochenkov petrochenkov deleted the useerr branch September 21, 2016 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petrochenkov @jseyfried @bors @alexcrichton