-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 20 pull requests #35908
Merged
Merged
Rollup of 20 pull requests #35908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue rust-lang#35799 as a part of issue rust-lang#35233 ?r jonathandturner
Fixes rust-lang#35797. Signed-off-by: Johannes Löthberg <[email protected]>
Fixes rust-lang#35703 Part of rust-lang#35233
Update lib.rs Update lib.rs Update E0438.rs Update E0437.rs Update E0435.rs
It used to say "Furtheremore" instead of "Furthermore".
A single missing article
I may have gone a bit overboard on this one. Numbers are fun. tone down the error message
reformat method chain according to ubsan Rustic Style Guide https://ubsan.github.io/style/
Updated error message E0388 Fixes rust-lang#35339 as part of rust-lang#35233. r? @GuillaumeGomez
Update E0033 to the new error format Part of rust-lang#35233 Addresses rust-lang#35498 "r? @jonathandturner
… r=GuillaumeGomez replace `BitAnd` example with something more evocative of bitwise AND
…urner Update E0503 to the new format Fixes rust-lang#35703 Part of rust-lang#35233 r? @jonathandturner
…andturner Updated E0054, E0423 & E0432 to new error format Fixes rust-lang#35791, rust-lang#35796 and rust-lang#35344, as part of rust-lang#35233 r? @jonathandturner
…ndturner Err codes r? @jonathandturner
…urner New format for E0426 Issue rust-lang#35799 as a part of issue rust-lang#35233 r? jonathandturner
…Gomez Update E0424 to the new error format Fixes rust-lang#35797. Part of rust-lang#35233. r? @GuillaumeGomez
Fix typos in unix/rwlock.rs r? @steveklabnik
…omez E0435, E0437 & E0438 New Error Format Part of rust-lang#35801 , rust-lang#35802 and rust-lang#35803 r? @GuillaumeGomez Hi! Please review the changes.
…aumeGomez replace `Mul` example with something more evocative of multiplication I may have gone a bit overboard on this one. Numbers are fun.
…aumeGomez replace `Rem` example with something more evocative r? @steveklabnik
…llaumeGomez replace `Index` example with something more evocative of indexing r? @steveklabnik
…illaumeGomez replace `println!` statements with `assert!`ions in `std::ptr` examples r? @steveklabnik
Fix "Furthermore" Typo in String Docs It used to say "Furtheremore" instead of "Furthermore".
…ple, r=GuillaumeGomez add example for `Rc::would_unwrap` Part of rust-lang#29372 r? @steveklabnik
rustc: Fix outdated comment cc rust-lang#35870 (comment) r? @eddyb
Minor type in CONTRIBUTING.md A single missing article
Add reference to `Self` in traits chapter (book) Addresses rust-lang#31891 "r? @steveklabnik
Add sublime-rust to CONFIGS.md. Just noticed it was missing! r? @steveklabnik
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=1 |
📌 Commit 8ea2936 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BitAnd
example with something more evocative of bitwise AND #35809, Update E0503 to the new format #35817, Updated E0054, E0423 & E0432 to new error format #35820, Err codes #35824, New format for E0426 #35835, Update E0424 to the new error format #35841, Fix typos in unix/rwlock.rs #35842, E0435, E0437 & E0438 New Error Format #35858, replaceMul
example with something more evocative of multiplication #35860, replaceRem
example with something more evocative #35861, replaceIndex
example with something more evocative of indexing #35864, replaceprintln!
statements withassert!
ions instd::ptr
examples #35878, Fix "Furthermore" Typo in String Docs #35879, add example forRc::would_unwrap
#35881, rustc: Fix outdated comment #35882, Minor typo in CONTRIBUTING.md #35889, Add reference toSelf
in traits chapter (book) #35891, Add sublime-rust to CONFIGS.md. #35901