-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build llvm with systemz backend enabled, and link to related libraries #36080
Conversation
when building rust against system llvm closes rust-lang#36077
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@@ -131,12 +131,19 @@ LLVMRustAddPass(LLVMPassManagerRef PM, LLVMPassRef rust_pass) { | |||
#define SUBTARGET_PPC | |||
#endif | |||
|
|||
#ifdef LLVM_COMPONENT_SYSTEMZ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to related libraries when building rust against system llvm
this fixes the travis builds. We could add a build slave that tests building rust against system llvm to avoid these in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build slave
I meant bors. Travis doesn't block PRs.
cc @TimNN |
Thanks @japaric! I'll wait to r+ until travis is green |
@bors: r+ |
📌 Commit 15d8dfb has been approved by |
⌛ Testing commit 15d8dfb with merge 06ab76a... |
💔 Test failed - auto-mac-64-opt-rustbuild |
@bors retry |
@bors p=1 |
build llvm with systemz backend enabled, and link to related libraries when building rust against system llvm closes #36077 r? @alexcrichton
when building rust against system llvm
closes #36077
r? @alexcrichton