Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build llvm with systemz backend enabled, and link to related libraries #36080

Merged
merged 1 commit into from
Aug 29, 2016

Conversation

japaric
Copy link
Member

@japaric japaric commented Aug 28, 2016

when building rust against system llvm

closes #36077

r? @alexcrichton

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -131,12 +131,19 @@ LLVMRustAddPass(LLVMPassManagerRef PM, LLVMPassRef rust_pass) {
#define SUBTARGET_PPC
#endif

#ifdef LLVM_COMPONENT_SYSTEMZ
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to related libraries when building rust against system llvm

this fixes the travis builds. We could add a build slave that tests building rust against system llvm to avoid these in the future

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build slave

I meant bors. Travis doesn't block PRs.

@japaric
Copy link
Member Author

japaric commented Aug 28, 2016

cc @TimNN

@alexcrichton
Copy link
Member

Thanks @japaric! I'll wait to r+ until travis is green

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 28, 2016

📌 Commit 15d8dfb has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 29, 2016

⌛ Testing commit 15d8dfb with merge 06ab76a...

@bors
Copy link
Contributor

bors commented Aug 29, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@arielb1
Copy link
Contributor

arielb1 commented Aug 29, 2016

@bors retry

@arielb1
Copy link
Contributor

arielb1 commented Aug 29, 2016

@bors p=1

@bors
Copy link
Contributor

bors commented Aug 29, 2016

⌛ Testing commit 15d8dfb with merge 77d2cd2...

bors added a commit that referenced this pull request Aug 29, 2016
build llvm with systemz backend enabled, and link to related libraries

when building rust against system llvm

closes #36077

r? @alexcrichton
@bors bors merged commit 15d8dfb into rust-lang:master Aug 29, 2016
@japaric japaric deleted the systemz branch August 29, 2016 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis is failing ("undefined reference to LLVMInitializeSystemZ*")
5 participants