-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a better error when using --test with #[proc_macro_derive] #37826
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! I do think though that This to me seems like the most conservative option with respect to the compiler, however, so seems reasonable to me. @rust-lang/compiler thoughts about taking this strategy? (erroring on |
I agree that it should work, but there are probably a few questions that need answering first. Fixing the misleading errors is probably a good start. |
True yeah, I'll go ahead and r+ and we can discuss further strategies in parallel. @bors: r+ |
📌 Commit 3254fab has been approved by |
Show a better error when using --test with #[proc_macro_derive] Fixes #37480 Currently using `--test` with a crate that contains a `#[proc_macro_derive]` attribute causes an error. This PR doesn't attempt to fix the issue itself, or determine what tesing of a proc_macro_derive crate should be - just to provide a better error message.
Fixes #37480
Currently using
--test
with a crate that contains a#[proc_macro_derive]
attribute causes an error. This PR doesn't attempt to fix the issue itself, or determine what tesing of a proc_macro_derive crate should be - just to provide a better error message.