Fix covered-switch-default warnings in RustWrapper #39063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These switch statements cover all possible values, so the default case is dead code (it contains an llvm_unreachable anyway), triggering a -Wcovered-switch-default warning. Moving the unreachable after the switch resolves these warnings. This keeps the build output clean.
|
@bors: r+ |
|
📌 Commit 004f18d has been approved by |
bors
added a commit
that referenced
this pull request
Jan 15, 2017
Fix covered-switch-default warnings in RustWrapper These switch statements cover all possible values, so the default case is dead code (it contains an `llvm_unreachable anyway`), triggering a `-Wcovered-switch-default` warning that pollutes the build output. Moving the unreachable after the switch resolves these warnings. r? @rkruppe
|
☀️ Test successful - status-appveyor, status-travis |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 8, 2017
(See rust-lang#39063 for explanation)
bors
added a commit
that referenced
this pull request
Aug 9, 2017
Fix covered-switch-default warnings in PassWrapper (See #39063 for explanation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These switch statements cover all possible values, so the default case is dead code (it contains an
llvm_unreachable anyway), triggering a-Wcovered-switch-defaultwarning that pollutes the build output. Moving the unreachable after the switch resolves these warnings.r? @rkruppe