Stop warning when doc testing proc macro crates #39136
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Given the following error from the travis test, this PR definitely seems like the wrong approach. |
|
@alexcrichton Do you have any thoughts on where to go from here? Adding the |
|
@keeperofdakeys I think we have a flag in options for "I am rustdoc please abort proc macro parsing early", could that be reused here? |
Add the actually_rustdoc option to the session that is passed to phase_2_configure_and_expand function inside the rustdoc test module. This prevents the warning code from triggering when parsing proc_macro_derive attributes, just like when `--test` is normally invoked.
keeperofdakeys
force-pushed
the
proc-macro-doc-test
branch
from
d4cdb0c to
c759aea
Compare
keeperofdakeys
changed the title
|
I've changed from using the |
|
@bors: r+ |
|
📌 Commit d492433 has been approved by |
|
@bors: p=1 (fixing the regression here: #37480 (comment)) |
…hton Stop warning when doc testing proc macro crates Fixes #39064 Add the test option to the session struct that is passed to phase_2_configure_and_expand function inside the rustdoc test module. This prevents the warning code from triggering when parsing proc_macro_derive attributes, just like when `--test` is normally invoked. This change makes the warning disappear, but I'm not sure what else it might change. So this early PR is mainly to run the test suite, and to get feedback.
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #39064
Add the test option to the session struct that is passed
to phase_2_configure_and_expand function inside the
rustdoc test module.
This prevents the warning code from triggering when
parsing proc_macro_derive attributes, just like when
--testis normally invoked.This change makes the warning disappear, but I'm not sure what else it might change. So this early PR is mainly to run the test suite, and to get feedback.