Remove alternative main feature #39337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
cramertj
changed the title
cramertj
force-pushed
the
cramertj/no-more-main
branch
from
c4d03a7 to
08c7384
Compare
|
@cramertj hmm the only problem I see on travis is that you have exceeded the 100 character line limit, which should be relatively easy to fix. |
|
Weird. Must be something messed up locally. Thanks for the heads-up! |
cramertj
force-pushed
the
cramertj/no-more-main
branch
from
08c7384 to
b9ce642
Compare
cramertj
force-pushed
the
cramertj/no-more-main
branch
from
b9ce642 to
d5da4a5
Compare
cramertj
changed the title
|
@nikomatsakis The issues I mentioned are showing up in travis now that I fixed the line length. |
cramertj
commented
Jan 27, 2017
| @@ -468,7 +468,6 @@ pub const BUILTIN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeG | |||
|
|
|||
| ("cfg", Normal, Ungated), | |||
| ("cfg_attr", Normal, Ungated), | |||
| ("main", Normal, Ungated), | |||
There was a problem hiding this comment.
Seems weird that this was ungated. Maybe that has to do with the issue.
Edit: Doesn't look like it. Adding that line back in didn't make any difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29634.
WIP because I'm still getting two errors:
compile-fail/test-warns-dead-codeis giving an unused attribute errorcompile-fail/issue-12997-2isn't giving the expected mismatched type errorI'm not sure I understand how either of these are related to the
mainfeature, so I'm going to return to this tomorrow after I've gotten some sleep. If anyone has an idea might be causing this, I'd appreciate a hint.