Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compile fail test for SIMD #40101

Merged
merged 1 commit into from
Mar 3, 2017
Merged

Add compile fail test for SIMD #40101

merged 1 commit into from
Mar 3, 2017

Conversation

danobi
Copy link
Contributor

@danobi danobi commented Feb 25, 2017

This completes the missing SIMD test task for issue #39059.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Looks great, thanks!

@bors
Copy link
Contributor

bors commented Feb 25, 2017

📌 Commit 9e51958 has been approved by alexcrichton

@frewsxcv frewsxcv mentioned this pull request Feb 26, 2017
Closed
@bors
Copy link
Contributor

bors commented Feb 26, 2017

⌛ Testing commit 9e51958 with merge c76fabf...

@bors
Copy link
Contributor

bors commented Feb 26, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Feb 26, 2017 via email

@bors
Copy link
Contributor

bors commented Feb 26, 2017

⌛ Testing commit 9e51958 with merge ac0b2ad...

@bors
Copy link
Contributor

bors commented Feb 26, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Feb 26, 2017 via email

@est31 est31 mentioned this pull request Feb 27, 2017
Closed
20 tasks
@aturon
Copy link
Member

aturon commented Feb 28, 2017

@bors: retry

@aturon
Copy link
Member

aturon commented Feb 28, 2017

@bors: r=alexcrichton

@bors
Copy link
Contributor

bors commented Feb 28, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Feb 28, 2017

📌 Commit 9e51958 has been approved by alexcrichton

@eddyb eddyb mentioned this pull request Feb 28, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Feb 28, 2017
Merged
bors added a commit that referenced this pull request Feb 28, 2017
@bors
Auto merge of #40148 - frewsxcv:rollup, r=frewsxcv
be76056 
Rollup of 9 pull requests

- Successful merges: #39977, #40033, #40047, #40056, #40057, #40122, #40124, #40126, #40131
- Failed merges: #40101
@bors
Copy link
Contributor

bors commented Feb 28, 2017

☔ The latest upstream changes (presumably #40148) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

@danobi want to rebase this to r+ again?

@danobi danobi force-pushed the feat_gate_test_simd branch from 9e51958 to dc53e56 Compare March 3, 2017 00:40
@danobi
Copy link
Contributor Author

danobi commented Mar 3, 2017

Done

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 3, 2017

📌 Commit dc53e56 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 3, 2017

⌛ Testing commit dc53e56 with merge b1e3176...

bors added a commit that referenced this pull request Mar 3, 2017
@bors
Auto merge of #40101 - danobi:feat_gate_test_simd, r=alexcrichton
b1e3176 
Add compile fail test for SIMD

This completes the missing SIMD test task for issue #39059.
@bors
Copy link
Contributor

bors commented Mar 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b1e3176 to master...

@bors bors merged commit dc53e56 into rust-lang:master Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danobi @rust-highfive @alexcrichton @bors @aturon