Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #40506

Closed
wants to merge 22 commits into from
Closed

Rollup of 9 pull requests #40506

wants to merge 22 commits into from

Conversation

tbu- and others added 22 commits March 9, 2017 13:45
It is more robust to not fail if any directory in a path was created
concurrently. This change lifts rustc internal `create_dir_racy` that
was created to handle such conditions to be new `create_dir_all`
implementation.
It will now correctly fail on existing non-directories.
As of last year with version 'Sierra', the Mac operating system is now
called 'macOS'.
Fix race condition in fs::create_dir_all

The code would crash if the directory was created after create_dir_all
checked whether the directory already existed.  This was contrary to
the documentation which claimed to create the directory if it doesn't
exist, implying (but not stating) that there would not be a failure
due to the directory existing.
Reword the non-dropping of `src` for `ptr::write{,_unaligned}`

@niconii Is it OK if I put your wording into the documentation?
CC @nagisa
Add test for issue rust-lang#29595

Closes rust-lang#29595

Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
…bnik

Update usages of 'OSX' (and other old names) to 'macOS'.

As of last year with version 'Sierra', the Mac operating system is now
called 'macOS'.
…g, r=steveklabnik

Remove doc about highlighting code in other languages rust-lang#40301

This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301

Thoughts:
- may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;
- does `text` still work?

r? @steveklabnik
Updating README.md to point to the correct doc location
fix format grammar

This is just a trivial change to get the escaped squigglies into the grammar.

r? @steveklabnik
…rewsxcv

Using X headings rust-lang#39850

Fix for issue rust-lang#39850, the headings should now be 1, 2, and 3.
…sfackler

std: remove a workaround for privacy limitations

`std::thread::Thread` implements a non-exported `NewThread` trait to allow for internal-only use of `Thread::new`. Nowadays we have `pub(crate)`, which accomplishes the same thing but much more idiomatically.

Rustdoc handles this correctly (I checked and I didn't see `Thread::new` on the rustdoc entry for `Thread` with this change), and the stage1 `rustc` emits the correct error still (I'm assuming that the stage1 compiler uses my `libstd`?):

```
$ ./build/x86_64-apple-darwin/stage1/bin/rustc test.rs
error: method `new` is private
 --> test.rs:4:18
  |
4 |     let thread = thread::Thread::new(None);
  |                  ^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error
```
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Mar 14, 2017

📌 Commit 110129b has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented Mar 14, 2017

⌛ Testing commit 110129b with merge 9847c66...

@bors
Copy link
Contributor

bors commented Mar 14, 2017

💔 Test failed - status-appveyor

@frewsxcv frewsxcv closed this Mar 14, 2017
@frewsxcv frewsxcv deleted the rollup branch March 14, 2017 13:05
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.