Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update older URLs pointing to the first edition of the Book #42623

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

tirr-c
Copy link
Contributor

@tirr-c tirr-c commented Jun 13, 2017

Fixes #42589.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Jun 13, 2017

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned eddyb Jun 13, 2017
@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2017
@arielb1
Copy link
Contributor

arielb1 commented Jun 13, 2017

Thanks for the PR @VBChunguk! @steveklabnik (or someone else) will be reviewing your PR soon.

@bors
Copy link
Contributor

bors commented Jun 14, 2017

☔ The latest upstream changes (presumably #42523) made this pull request unmergeable. Please resolve the merge conflicts.

`compiler-plugins.html` is moved into the Unstable Book.
Explanation is slightly modified to match the change.
@steveklabnik
Copy link
Member

r=me when travis passes. Thanks @VBChunguk !

@GuillaumeGomez
Copy link
Member

@bors: r=steveklabnik

@bors
Copy link
Contributor

bors commented Jun 15, 2017

📌 Commit 3cb7825 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Jun 15, 2017

⌛ Testing commit 3cb7825 with merge 16c27bf...

bors added a commit that referenced this pull request Jun 15, 2017
Update older URLs pointing to the first edition of the Book

Fixes #42589.
@bors
Copy link
Contributor

bors commented Jun 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing 16c27bf to master...

@bors bors merged commit 3cb7825 into rust-lang:master Jun 15, 2017
@tirr-c tirr-c deleted the fix-older-urls branch June 15, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants