-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Debug for Args and ArgsOs #42798
Conversation
Display actual args instead of two dots.
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
I didn't check it on Windows. Is there a way to ask some build system to check it? |
Not really; well, the code will be compiled and tested on Windows when r+-ed. With the right toolchains locally that's not an issue, but I wouldn't worry about it. |
OK, I managed to compile it under VirtualBox and fixed it. |
@bors r+ |
📌 Commit 14c8184 has been approved by |
Test seems to be broken on Linux. Seems like args is empty on Linux. Trying to reproduce it now on Linux. |
@bors r- |
Should be OK now. Do |
@bors r+ |
📌 Commit 275f9a0 has been approved by |
@bors rollup |
Better Debug for Args and ArgsOs Display actual args instead of two dots.
Better Debug for Args and ArgsOs Display actual args instead of two dots.
Better Debug for Args and ArgsOs Display actual args instead of two dots.
☀️ Test successful - status-appveyor, status-travis |
Display actual args instead of two dots.