only set "overruled by outer forbid" once for lint groups, by group name #42874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long ago, in the before-time, the find_lint method was created with the
unused_variables ("unused_variable" in the singular, as it was called at
the time) attribute in anticipation of using the session and span in the
handling of renamed lints (31b7d64), and indeed, the session and span
came to be used in this method, while the unused_variables attribute
remained (1ad1e2e). In modern times, the session and span are again no
longer used (ca81d3d); it seems we can safely prune them from the
method signature, for justice, and mercy.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
zackmdavis
force-pushed
the
overzealous_by_outer_forbid
branch
from
e7a5b6f to
940a02f
Compare
|
(force-pushed to fix Travis tidy failure) |
Previously, conflicting forbid/allow attributes for a lint group would result in a separate "allow(L) overruled by outer forbid(L)" error for every lint L in the group. This was needlessly and annoyingly verbose; we prefer to just have one error pointing out the conflicting attributes. Resolves rust-lang#42873.
zackmdavis
force-pushed
the
overzealous_by_outer_forbid
branch
from
940a02f to
890a76f
Compare
|
(force-push again to fix Travis compile-fail failure) 😰 |
Mark-Simulacrum
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 890a76f has been approved by |
|
@bors rollup |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Jun 27, 2017
…bid, r=nikomatsakis only set "overruled by outer forbid" once for lint groups, by group name Previously, conflicting forbid/allow attributes for a lint group would result in a separate "allow(L) overruled by outer forbid(L)" error for every lint L in the group. This was needlessly and annoyingly verbose; we prefer to just have one error pointing out the conflicting attributes. (Also, while we're touching context.rs, clean up some unused arguments.) Resolves rust-lang#42873.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, conflicting forbid/allow attributes for a lint group would
result in a separate "allow(L) overruled by outer forbid(L)" error for
every lint L in the group. This was needlessly and annoyingly verbose;
we prefer to just have one error pointing out the conflicting
attributes.
(Also, while we're touching context.rs, clean up some unused arguments.)
Resolves #42873.