Rewrite std::net::ToSocketAddrs doc examples.
#44117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
src/libstd/net/addr.rs
Outdated
| /// ``` | ||
| /// use std::net::{ToSocketAddrs, SocketAddr}; | ||
| /// | ||
| /// let mut addrs_iter = ((127, 0, 0, 1), 443).to_socket_addrs().unwrap(); |
There was a problem hiding this comment.
Looks like there's not an impl for ((u8, u8, u8, u8), u16)? Maybe you still need a Ipv4Addr::new?
src/libstd/net/addr.rs
Outdated
| /// // assuming 'localhost' resolves to 127.0.0.1 | ||
| /// let mut addrs_iter = "localhost:443".to_socket_addrs().unwrap(); | ||
| /// assert_eq!(addrs_iter.next(), Some(SocketAddr::from(([127, 0, 0, 1], 443)))); | ||
| /// assert!(addrs_iter.next().is_none(); |
src/libstd/net/addr.rs
Outdated
| /// use std::io; | ||
| /// use std::net::ToSocketAddrs; | ||
| /// | ||
| /// let err = "127.0.0:80".to_socket_addrs().unwrap_err(); |
There was a problem hiding this comment.
this actually appears to have successfully called to_socket_addrs o_O
called `Result::unwrap_err()` on an `Ok` value: IntoIter([V4(127.0.0.0:80)])
src/libstd/net/addr.rs
Outdated
| /// | ||
| /// let err = "127.0.0:80".to_socket_addrs().unwrap_err(); | ||
| /// assert_eq!(err.kind(), io::ErrorKind::InvalidInput); | ||
| /// ``` |
There was a problem hiding this comment.
Is setting this to no_run the right call? Especially if it actually resolved an address in the last run? If we want to show an example of it not resolving the address, we could just leave off the port; that will cause a failure.
src/libstd/net/addr.rs
Outdated
| /// ``` | ||
| /// use std::net::{ToSocketAddrs, SocketAddr}; | ||
| /// | ||
| /// let addr = SocketAddr::from(([127, 0, 0, 1], 443); |
There was a problem hiding this comment.
missing close paren, this is the travis failure
|
tests pass now. i'll squash whenever this gets approved |
carols10cents
added
the
S-waiting-on-review
|
Looks good! Go ahead and squash and r=me. |
in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios
frewsxcv
force-pushed
the
frewsxcv-to-socket-addrs-examples
branch
from
043382c to
10bd39e
Compare
|
@bors r=QuietMisdreavus rollup |
|
📌 Commit 10bd39e has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
…xamples, r=QuietMisdreavus Rewrite `std::net::ToSocketAddrs` doc examples. in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios done this as preliminary work while investigating rust-lang#22569 note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
…xamples, r=QuietMisdreavus Rewrite `std::net::ToSocketAddrs` doc examples. in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios done this as preliminary work while investigating rust-lang#22569 note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
…xamples, r=QuietMisdreavus Rewrite `std::net::ToSocketAddrs` doc examples. in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios done this as preliminary work while investigating rust-lang#22569 note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 29, 2017
…xamples, r=QuietMisdreavus Rewrite `std::net::ToSocketAddrs` doc examples. in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios done this as preliminary work while investigating rust-lang#22569 note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving
arielb1
added
S-waiting-on-bors
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Aug 29, 2017
…xamples, r=QuietMisdreavus Rewrite `std::net::ToSocketAddrs` doc examples. in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios done this as preliminary work while investigating rust-lang#22569 note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Aug 29, 2017
…xamples, r=QuietMisdreavus Rewrite `std::net::ToSocketAddrs` doc examples. in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios done this as preliminary work while investigating rust-lang#22569 note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in particular:
done this as preliminary work while investigating #22569
note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving