core: derive Clone for result::IntoIter #45179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears to be a simple oversight that `result::IntoIter<T>` doesn't implement `Clone` (where `T: Clone`). We do already have `Clone` for `result::Iter`, as well as the similar `option::IntoIter` and `Iter`.
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
|
I suppose by using |
|
@cuviper No need to break it out, since |
aidanhs
added
the
S-waiting-on-review
|
ping @BurntSushi for review! pinging you on irc too :) |
|
Sounds good to me! @bors r+ |
|
📌 Commit 9e8b33e has been approved by |
bors
added a commit
that referenced
this pull request
Oct 17, 2017
core: derive Clone for result::IntoIter It appears to be a simple oversight that `result::IntoIter<T>` doesn't implement `Clone` (where `T: Clone`). We do already have `Clone` for `result::Iter`, as well as the similar `option::IntoIter` and `Iter`.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to be a simple oversight that
result::IntoIter<T>doesn'timplement
Clone(whereT: Clone). We do already haveCloneforresult::Iter, as well as the similaroption::IntoIterandIter.