Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc book: Add missing headlines #45308

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Rustdoc book: Add missing headlines #45308

merged 1 commit into from
Oct 17, 2017

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Oct 15, 2017

Some options were missing headlines, which looked a bit inconsistent.

Some options were missing headlines, which looked a bit inconsistent.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @frewsxcv (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2017
@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you!

@bors
Copy link
Contributor

bors commented Oct 15, 2017

📌 Commit fdb3e37 has been approved by steveklabnik

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2017
@frewsxcv frewsxcv removed their assignment Oct 17, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 17, 2017
Rustdoc book: Add missing headlines

Some options were missing headlines, which looked a bit inconsistent.
bors added a commit that referenced this pull request Oct 17, 2017
Rollup of 10 pull requests

- Successful merges: #45097, #45151, #45307, #45308, #45310, #45315, #45321, #45329, #45338, #45339
- Failed merges:
@bors bors merged commit fdb3e37 into rust-lang:master Oct 17, 2017
@dbrgn dbrgn deleted the headlines branch December 18, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants