Add a MIR-borrowck-only output mode #46106
Conversation
est31
changed the title
|
r? @nikomatsakis or someone else |
kennytm
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 59780fe has been approved by |
kennytm
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #46040) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Needs rebase, I'm afraid. |
|
The PR touches every single MIR borrowck test... it is expectable that there is a little breakage :). This probably won't be the last time I'll have to do a rebase but I don't mind that. The PR should be rebased again re-r? @nikomatsakis |
|
@bors r+ |
|
📌 Commit 291ac56 has been approved by |
|
@bors p=1 |
|
Heh, I almost did the same thing (p=1) but then reconsidered for the same reason. |
|
☔ The latest upstream changes (presumably #46087) made this pull request unmergeable. Please resolve the merge conflicts. |
|
re-r? @nikomatsakis |
where mode is one of {ast,mir,compare}.
This commit only implements the functionality.
The tests will be updated in a follow up commit.
|
@bors r=nikomatsakis |
|
📌 Commit d791798 has been approved by |
Add a MIR-borrowck-only output mode Removes the `-Z borrowck-mir` flag in favour of a `-Z borrowck=mode` flag where mode can be `mir`, `ast`, or `compare`. * The `ast` mode represents the current default, passing `-Z borrowck=ast` is equivalent to not passing it at all. * The `compare` mode outputs both the output of the MIR borrow checker and the AST borrow checker, each error with `(Ast)` and `(Mir)` appended. This mode has the same behaviour as `-Z borrowck-mir` had before this commit. * The `mir` mode only outputs the results of the MIR borrow checker, while suppressing the errors of the ast borrow checker The PR also updates the tests to use the new flags. closes #46097
|
☀️ Test successful - status-appveyor, status-travis |
Removes the
-Z borrowck-mirflag in favour of a-Z borrowck=modeflag where mode can bemir,ast, orcompare.astmode represents the current default, passing-Z borrowck=astis equivalent to not passing it at all.comparemode outputs both the output of the MIR borrow checker and the AST borrow checker, each error with(Ast)and(Mir)appended. This mode has the same behaviour as-Z borrowck-mirhad before this commit.mirmode only outputs the results of the MIR borrow checker, while suppressing the errors of the ast borrow checkerThe PR also updates the tests to use the new flags.
closes #46097