-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a typo in ToSocketAddrs documentation #46141
Conversation
Fix a typo in ToSocketAddrs documentation: s/ToSocketsAddr/ToSocketAddrs
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aqrln! This looks good to me.
@bors r+ |
@KodrAus: 🔑 Insufficient privileges: Not in reviewers |
:( |
r? @frewsxcv |
thanks! @bors r+ rollup |
📌 Commit 0789a1d has been approved by |
…=frewsxcv Fix a typo in ToSocketAddrs documentation Fix a typo in `ToSocketAddrs` documentation: s/ToSocketsAddr/ToSocketAddrs
Thanks! Happy to have my first contribution to Rust and hope this isn't the last one :) |
Hi! Today I noticed that the typo is still there at https://doc.rust-lang.org/std/net/trait.ToSocketAddrs.html. AFAICT the patch has never made it into any release. I'm not aware of the exact release process and policies but heads up if it should have. |
Fix a typo in
ToSocketAddrs
documentation: s/ToSocketsAddr/ToSocketAddrs