-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mention nightly in -Z external-macro-backtrace note #46168
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
I buy the rationale. If you disagree, please r- and assign yourself as the reviewer. |
📌 Commit 95de1a2 has been approved by |
⌛ Testing commit 95de1a20664a2fb708dc7557993efc4232b4c3c9 with merge d80dce2a8acab980568114a0d5eeb45992c36abb... |
💔 Test failed - status-travis |
One missing change in error: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead? (see issue #27812)
--> $DIR/issue-44953.rs:16:14
|
16 | #[macro_use] extern crate log; //~ ERROR use of unstable library feature
| ^^^^^^^^^^^^^^^^^
|
= help: add #![feature(rustc_private)] to the crate attributes to enable
error: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead? (see issue #27812)
--> $DIR/issue-44953.rs:19:5
|
19 | info!("This is a log message.");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: add #![feature(rustc_private)] to the crate attributes to enable
- = note: this error originates in a macro outside of the current crate (run with -Z external-macro-backtrace for more info)
+ = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) @bors p=1 — Anticipating fragility. |
@bors delegate+ |
✌️ @durka can now approve this pull request |
95de1a2
to
5da957c
Compare
@bors r+ |
📌 Commit 5da957c has been approved by |
mention nightly in -Z external-macro-backtrace note Fix #46167 by mentioning that you need nightly in the message that tells you to pass `-Z external-macro-backtrace`. Rationale: 1. The reason for having this message is to increase discoverability of the functionality. If the message is only shown on nightly it's less disoverable. 2. The same approach is taken if you call a const fn in const context without its feature gate (previously, if you called it without `#![feature(const_fn)]`). cc @kennytm
☀️ Test successful - status-appveyor, status-travis |
Fix #46167 by mentioning that you need nightly in the message that tells you to pass
-Z external-macro-backtrace
.Rationale:
#![feature(const_fn)]
).cc @kennytm