incr.comp.: Make traits::VTable encodable and decodable. #46400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Nov 30, 2017
| const VTABLE_BUILTIN: u8 = 4; | ||
| const VTABLE_CLOSURE: u8 = 5; | ||
| const VTABLE_FN_POINTER: u8 = 6; | ||
| const VTABLE_GENERATOR: u8 = 7; |
There was a problem hiding this comment.
Wait, since when do we do this manually?!
michaelwoerister
force-pushed
the
vtable-encodable
branch
from
bdfe440 to
780f4ed
Compare
eddyb
approved these changes
Nov 30, 2017
|
@bors r+ |
|
📌 Commit 780f4ed has been approved by |
kennytm
added
S-waiting-on-review
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…r=eddyb incr.comp.: Make traits::VTable encodable and decodable. Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point. r? @eddyb
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…r=eddyb incr.comp.: Make traits::VTable encodable and decodable. Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point. r? @eddyb
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…r=eddyb incr.comp.: Make traits::VTable encodable and decodable. Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point. r? @eddyb
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 1, 2017
…r=eddyb incr.comp.: Make traits::VTable encodable and decodable. Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point. r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make vtables encodable so we can cache the
trans_fulfill_obligationquery at some point.r? @eddyb