Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point at unknown lang item attribute #47691

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Point at unknown lang item attribute #47691

merged 1 commit into from
Jan 25, 2018

Conversation

estebank
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@hanna-kruppe
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 23, 2018

📌 Commit 5f24efd has been approved by rkruppe

@estebank estebank added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 24, 2018
@estebank
Copy link
Contributor Author

@bors rollup

@estebank estebank force-pushed the unknown-lang-item-sp branch from 5f24efd to 5ec7082 Compare January 24, 2018 01:03
@estebank
Copy link
Contributor Author

@bors r=rkruppe

@bors
Copy link
Contributor

bors commented Jan 24, 2018

📌 Commit 5ec7082 has been approved by rkruppe

@estebank estebank force-pushed the unknown-lang-item-sp branch from 5ec7082 to dd8ae6d Compare January 24, 2018 02:24
@estebank
Copy link
Contributor Author

@bors r=rkruppe

@bors
Copy link
Contributor

bors commented Jan 24, 2018

📌 Commit dd8ae6d has been approved by rkruppe

scottmcm
scottmcm reviewed Jan 24, 2018
View reviewed changes
src/librustc/middle/lang_items.rs Outdated
let mut err = struct_span_err!(self.tcx.sess, span, E0522,
"definition of an unknown language item: `{}`",
value);
err.span_label(span, format!("definition of unkown language item `{}`", value));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unkown should be unknown

@estebank estebank force-pushed the unknown-lang-item-sp branch from dd8ae6d to e6af9eb Compare January 24, 2018 05:37
@estebank
Copy link
Contributor Author

@bors r=rkruppe

third's the charm

@bors
Copy link
Contributor

bors commented Jan 24, 2018

📌 Commit e6af9eb has been approved by rkruppe

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 25, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47691 - estebank:unknown-lang-item-sp, r=rk…
7550753 
…ruppe

Point at unknown lang item attribute
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47691 - estebank:unknown-lang-item-sp, r=rk…
df55cee 
…ruppe

Point at unknown lang item attribute
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 25, 2018
Merged
bors added a commit that referenced this pull request Jan 25, 2018
@bors
Auto merge of #47740 - GuillaumeGomez:rollup, r=GuillaumeGomez
9fd7da9 
Rollup of 10 pull requests

- Successful merges: #47534, #47609, #47679, #47691, #47700, #47702, #47717, #47721, #47726, #47729
- Failed merges:
@bors bors merged commit e6af9eb into rust-lang:master Jan 25, 2018
@estebank estebank deleted the unknown-lang-item-sp branch November 9, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmcm scottmcm scottmcm left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@estebank @rust-highfive @hanna-kruppe @bors @scottmcm @nikomatsakis