Backport rustdoc ICE fixes to beta #47969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
Manishearth
added
the
beta-nominated
shepmaster
added
the
S-waiting-on-review
Mark-Simulacrum
removed
the
beta-nominated
|
I'm going to go ahead and land this since we believe it to be an adequate, and minimal, fix. We can revert and apply a different fix if necessary. @bors r+ p=10 |
|
📌 Commit c3cf9bc has been approved by |
|
⌛ Testing commit c3cf9bc with merge 69631fcf022795380b662e12d0ec821988005ced... |
|
💔 Test failed - status-appveyor |
bors
added a commit
that referenced
this pull request
Feb 3, 2018
Backport rustdoc ICE fixes to beta backport of #47959
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #47959