Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Feature Request instructions #48705

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Update Feature Request instructions #48705

merged 1 commit into from
Mar 13, 2018

Conversation

klnusbaum
Copy link
Contributor

As noted in #48393 the contribution instructions for submitting a Feature Request are a little hasty, suggesting that the user immediately create an issue in the RFC repository. For users that want to submit a feature request, let's instead point them directly to the README file for the RFC repository, which contains detailed instructions on how to submit a Feature Request.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2018
@Centril Centril added the T-core Relevant to the core team, which will review and decide on the PR/issue. label Mar 4, 2018
@kennytm kennytm added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Mar 7, 2018
@pietroalbini
Copy link
Member

Thanks for this PR! The triage team will make sure @aturon (or someone from @rust-lang/docs) reviews this.

@aturon
Copy link
Member

aturon commented Mar 12, 2018

@bors: r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Mar 12, 2018

📌 Commit f9c5b1f has been approved by aturon

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 12, 2018
@kennytm
Rollup merge of rust-lang#48705 - klnusbaum:update_rfc_process, r=aturon
7bd8f6e 
Update Feature Request instructions

As noted in rust-lang#48393 the contribution instructions for submitting a Feature Request are a little hasty, suggesting that the user immediately create an issue in the RFC repository. For users that want to submit a feature request, let's instead point them directly to the README file for the RFC repository, which contains detailed instructions on how to submit a Feature Request.
@kennytm kennytm mentioned this pull request Mar 12, 2018
Merged
bors added a commit that referenced this pull request Mar 12, 2018
@bors
Auto merge of #48955 - kennytm:rollup, r=kennytm
c7cbe14 
Rollup of 13 pull requests

- Successful merges: #48201, #48705, #48725, #48824, #48877, #48880, #48887, #48928, #48934, #48480, #48631, #48898, #48954
- Failed merges:
@bors bors merged commit f9c5b1f into rust-lang:master Mar 13, 2018
@klnusbaum klnusbaum deleted the update_rfc_process branch March 16, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-core Relevant to the core team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@klnusbaum @rust-highfive @pietroalbini @aturon @bors @kennytm @Centril