Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless powerpc64 entry from ARCH_TABLE #48732

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Remove useless powerpc64 entry from ARCH_TABLE #48732

merged 1 commit into from
Mar 6, 2018

Conversation

debris
Copy link
Contributor

@debris debris commented Mar 4, 2018

Hope, I understood the scope of the fix correctly. closes #47737

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2018
@hanna-kruppe hanna-kruppe mentioned this pull request Mar 4, 2018
Closed
@alexcrichton
Copy link
Member

@bors: r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Mar 4, 2018

📌 Commit 16ac85c has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2018
@nagisa
Copy link
Member

nagisa commented Mar 4, 2018

I do not think this is an appropriate fix. #47737 (comment) matches my intuition well.

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 5, 2018
@Manishearth
Rollup merge of rust-lang#48732 - debris:remove_powerpc64, r=alexcric…
895ab22 
…hton

Remove useless powerpc64 entry from ARCH_TABLE

Hope, I understood the scope of the fix correctly. closes rust-lang#47737
@Manishearth Manishearth mentioned this pull request Mar 5, 2018
Closed
@kennytm kennytm mentioned this pull request Mar 6, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48732 - debris:remove_powerpc64, r=alexcric…
6b05c48 
…hton

Remove useless powerpc64 entry from ARCH_TABLE

Hope, I understood the scope of the fix correctly. closes rust-lang#47737
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48732 - debris:remove_powerpc64, r=alexcric…
64cb871 
…hton

Remove useless powerpc64 entry from ARCH_TABLE

Hope, I understood the scope of the fix correctly. closes rust-lang#47737
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 6, 2018
@kennytm
Rollup merge of rust-lang#48732 - debris:remove_powerpc64, r=alexcric…
178b2c4 
…hton

Remove useless powerpc64 entry from ARCH_TABLE

Hope, I understood the scope of the fix correctly. closes rust-lang#47737
bors added a commit that referenced this pull request Mar 6, 2018
@bors
Auto merge of #48768 - kennytm:rollup, r=kennytm
2789b06 
Rollup of 14 pull requests

- Successful merges: #48403, #48432, #48546, #48573, #48590, #48657, #48727, #48732, #48753, #48754, #48761, #48474, #48507, #47463
- Failed merges:
@alexcrichton alexcrichton merged commit 16ac85c into rust-lang:master Mar 6, 2018
@debris debris deleted the remove_powerpc64 branch March 6, 2018 20:00
@hanna-kruppe hanna-kruppe mentioned this pull request Mar 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiletest powerpc64 arch is useless
5 participants
@debris @rust-highfive @alexcrichton @bors @nagisa