Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor CI changes #48907

Merged
merged 2 commits into from
Mar 11, 2018
Merged

Some minor CI changes #48907

merged 2 commits into from
Mar 11, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Mar 10, 2018

  1. On macOS, ensure crash log printing won't error, and only real crash logs are printed. This may avoid the find process exiting abnormally and truncated the Travis log (I guess).

  2. Print /proc/cpuinfo and /proc/meminfo. To determine if there's any variation in the reported clock rate between jobs.

@kennytm
Copy link
Member Author

kennytm commented Mar 10, 2018

r? @alexcrichton

Still missing a standard benchmark to measure the real performance.

Would python -m timeit '(something)' be good?

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2018
@alexcrichton
Copy link
Member

@bors: r+

Nice! We'll probably at some point want to figure out the equivalent invocation for AppVeyor, but this is certainly better than before!

As for a standard benchmark as well yeah I'm fine w/ that coming later.

@bors
Copy link
Contributor

bors commented Mar 10, 2018

📌 Commit c67e553 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2018
@kennytm
Copy link
Member Author

kennytm commented Mar 10, 2018

@alexcrichton The cat /proc/cpuinfo and cat /proc/meminfo commands already work on AppVeyor because of MSYS2 (/proc/cpuinfo is how we get the CPU core count) 😃 Unless you want even more specific information 😉

@alexcrichton
Copy link
Member

Oh nice! I had no idea...

kennytm added a commit to kennytm/rust that referenced this pull request Mar 10, 2018
Some minor CI changes

1. On macOS, ensure crash log printing won't error, and only real crash logs are printed. This may avoid the `find` process exiting abnormally and truncated the Travis log (I guess).

2. Print `/proc/cpuinfo` and `/proc/meminfo`. To determine if there's any variation in the reported clock rate between jobs.
@bors
Copy link
Contributor

bors commented Mar 11, 2018

⌛ Testing commit c67e553 with merge 5f2efb0...

bors added a commit that referenced this pull request Mar 11, 2018
Some minor CI changes

1. On macOS, ensure crash log printing won't error, and only real crash logs are printed. This may avoid the `find` process exiting abnormally and truncated the Travis log (I guess).

2. Print `/proc/cpuinfo` and `/proc/meminfo`. To determine if there's any variation in the reported clock rate between jobs.
@bors
Copy link
Contributor

bors commented Mar 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5f2efb0 to master...

@bors bors merged commit c67e553 into rust-lang:master Mar 11, 2018
@kennytm kennytm deleted the minor-ci-stuff branch March 11, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants