Add primitive intra-links #49459
Merged
Add primitive intra-links #49459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
src/librustdoc/clean/mod.rs
Outdated
| if let Some(ref fragment) = *fragment { | ||
| // This is a primitive so the url is done "by hand". | ||
| Some((s.clone(), | ||
| format!("https://doc.rust-lang.org/{}std/primitive.{}.html", |
There was a problem hiding this comment.
We don't link to the stable std docs anywhere, since libstd itself has a doc_html_root set to the nightly docs. I would prefer if you could somehow grab the url root for std to combine with the "hand-made" primitive link, or at least always link to nightly.
src/librustdoc/clean/mod.rs
Outdated
| "i8", "i16", "i32", "i64", "i128", "isize", | ||
| "f32", "f64", | ||
| "str", "bool", "char"]; | ||
| const PRIMITIVES_DEF: &[Def] = &[Def::PrimTy(hir::PrimTy::TyUint(syntax::ast::UintTy::U8)), |
There was a problem hiding this comment.
If these listings are supposed to be related to each other, can you at least make it a &[(&str, Def)]? A map of some kind would be best, but since it's a const, the slice-of-tuples will work.
GuillaumeGomez
force-pushed
the
primitive-intra-links
branch
2 times, most recently
from
74426f7 to
039d291
Compare
GuillaumeGomez
force-pushed
the
primitive-intra-links
branch
from
039d291 to
561e8ef
Compare
|
Updated. |
27 tasks
|
Looks great! Thanks for getting into this! @bors r+ |
|
📌 Commit 561e8ef has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 31, 2018
…isdreavus Add primitive intra-links Part of #43466. r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43466.
r? @QuietMisdreavus