-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experimental]: Build LLVM with ThinLTO enabled #51207
[experimental]: Build LLVM with ThinLTO enabled #51207
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@Mark-Simulacrum, a try build will use the |
@bors: try Indeed! |
⌛ Trying commit 78166b9 with merge 47ba392a9c2024df43edf955ef33ab4499e65fe9... |
Note that this doesn't do much yet. I'm trying to pass some additional linker args when building |
I think I'll add a custom |
@bors try |
⌛ Trying commit e5bea083e25493d9a6a1d982da6632ca1961e1fb with merge 1ebfb3a317bd05bc8a04c8c5e8f9c3a9d706ed26... |
💔 Test failed - status-travis |
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
e5bea08
to
55aaf63
Compare
Fixed syntax error in docker file. @bors try |
⌛ Trying commit 55aaf63 with merge 27e14d156eb62d65d5092a053c153d6fc4851cf2... |
@michaelwoerister It might be easier to implement the "deferred args" thing via checking the |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
[experimental]: Build LLVM with ThinLTO enabled This is a work in progress. Let's see how it goes.
@kennytm, wait, what's going on here? https://travis-ci.org/rust-lang/rust/jobs/385738110 is still running 😕 |
This comment has been minimized.
This comment has been minimized.
@michaelwoerister Huh. Probably messed up due to having too many try builds in parallel. I've canceled the latest try build, let's manually monitor Travis for now. |
Ping from triage, @michaelwoerister! Do you think you'll be able to work on this again? |
I think I'll wait until #52019 is available in the bootstrap compiler. That will make things a lot nicer. |
Is it worth doing a (minor) beta backport to expedite this? |
No, I still need to implement proper Windows support for the linker-plugin-based LTO stuff. In any case, this is not too urgent. |
Ping from triage @michaelwoerister! It's been a while since we heard from you, will you have time to work on this again? |
Thank you for this PR @michaelwoerister! Unfortunately we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again! |
[experimental]: Build LLVM with ThinLTO enabled (2nd attempt) This is #51207 revived. This time, I'd like to run actual performance tests to see if it improves compile times.
[experimental]: Build LLVM with ThinLTO enabled (2nd attempt) This is #51207 revived. This time, I'd like to run actual performance tests to see if it improves compile times.
[experimental]: Build LLVM with ThinLTO enabled (2nd attempt) This is #51207 revived. This time, I'd like to run actual performance tests to see if it improves compile times.
[experimental]: Build LLVM with ThinLTO enabled (2nd attempt) This is #51207 revived. This time, I'd like to run actual performance tests to see if it improves compile times.
…hton [experimental]: Build LLVM with ThinLTO enabled (2nd attempt) This is #51207 revived. This time, I'd like to run actual performance tests to see if it improves compile times.
This is a work in progress. Let's see how it goes.