(still broken) str: stop encoding invalid code points #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure might have to do with the escape value |
|
Reducing the test-case, I can see this PR failing the assertion on the first case, ie. on a simple std::json::from_str(~"""). |
|
@thestinger Can this be closed? |
|
@brson: it's still an issue - the str module is encoding out-of-range utf-8 I just don't understand why |
The highest valid code point is 1114111 (0x10FFFF) and the modern UTF-8 standard guarantees that the maximum number of bytes needed to encode a code point is 4 (instead of 6, in the legacy standard). From <https://tools.ietf.org/html/rfc3629>: Changes from RFC 2279 o Restricted the range of characters to 0000-10FFFF (the UTF-16 accessible range).
|
Changing this into an issue, since it bitrotted. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Fix run-pass tests when CARGO_TARGET_DIR is not set r? @lzutao I got ``` thread '[ui] ui/crashes/ice-1969.rs' panicked at 'failed to exec `"target/debug/test_build_base/crashes/ice-1969.stage-id"`: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /home/pkrones/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/compiletest_rs-0.4.0/src/runtest.rs:1350:25 ``` on tests with `// run-pass` locally. The reason for this is, that I haven't set `CARGO_TARGET_DIR` and then `"target"` was used as the `CARGO_TARGET_DIR`. It seems, that `compiletest-rs` cannot deal with relative paths for `// run-pass` tests. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fails in the
json::tests::test_read_strtest. I'm not sure why.The highest valid code point is 1114111 (0x10FFFF) and the modern UTF-8
standard guarantees that the maximum number of bytes needed to encode a
code point is 4 (instead of 6, in the legacy standard).
From https://tools.ietf.org/html/rfc3629:
Changes from RFC 2279
o Restricted the range of characters to 0000-10FFFF (the UTF-16
accessible range).