Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine all builtin late lints #51678

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Combine all builtin late lints #51678

merged 1 commit into from
Jun 26, 2018
+177 −139

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jun 21, 2018

No description provided.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Jun 21, 2018

@bors try

@bors
Copy link
Contributor

bors commented Jun 21, 2018

⌛ Trying commit ebb4a708d79ded9db0860e92efd0042ae2e48334 with merge 467cf3c80ae91949cd435870ae33b27310c02d1c...

@kennytm
Copy link
Member

kennytm commented Jun 21, 2018

@Zoxc If you're trying for perf, we can't do it until #51680 is merged (see #51356 (comment)).

@bors
Copy link
Contributor

bors commented Jun 21, 2018

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc
Copy link
Contributor Author

Zoxc commented Jun 21, 2018

@bors try

@bors
Copy link
Contributor

bors commented Jun 21, 2018

⌛ Trying commit c5ecc6f with merge 8059be493eda3c285d334e22c36b80071ee2a2a4...

@kennytm
Copy link
Member

kennytm commented Jun 21, 2018

@bors r- try- retry

The try build is complete but we've restarted bors and got the states confused.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2018
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2018
@kennytm
Copy link
Member

kennytm commented Jun 24, 2018

@Mark-Simulacrum perf is requested try#8059be493eda3c285d334e22c36b80071ee2a2a4 vs master#f790780451a724dce9be0ba03ff217955036ff88.

@Mark-Simulacrum
Copy link
Member

Perf queued.

@Zoxc
Copy link
Contributor Author

Zoxc commented Jun 24, 2018

Result: https://perf.rust-lang.org/compare.html?start=f790780451a724dce9be0ba03ff217955036ff88&end=8059be493eda3c285d334e22c36b80071ee2a2a4&stat=instructions%3Au

@estebank
Copy link
Contributor

@Zoxc great! I feel comfortable merging this as is. Do you have any outstanding change before I approve?

@kennytm kennytm removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 25, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Jun 25, 2018

@estebank No, this should be good to go.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 25, 2018

📌 Commit c5ecc6f has been approved by estebank

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 25, 2018
@bors
Copy link
Contributor

bors commented Jun 26, 2018

⌛ Testing commit c5ecc6f with merge 2808460...

bors added a commit that referenced this pull request Jun 26, 2018
@bors
Auto merge of #51678 - Zoxc:combine-lints, r=estebank
2808460 
Combine all builtin late lints
@bors
Copy link
Contributor

bors commented Jun 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing 2808460 to master...

@bors bors merged commit c5ecc6f into rust-lang:master Jun 26, 2018
This was referenced Jun 26, 2018
Merged
Merged
@Zoxc Zoxc deleted the combine-lints branch August 6, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zoxc @rust-highfive @bors @kennytm @Mark-Simulacrum @estebank