-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for late-bound regions #53441
fix for late-bound regions #53441
Conversation
This seems reasonable, but I'm intrigued if this could introduce potential bugs... |
Sorry for the delay. Rust conf. This doesn't feel quite right to me, but let me investigate the code and say a bit more =) |
OK, I see now where the assert is failing. I pushed a commit that fixes this in a different way -- basically, doing a better job of the previous hack. If you recall, @toidiu, we already modified the code to just ignore I also added a newtype for the bool to make it a bit more self documenting. Weird quirk I have. What do you think? |
0178c88
to
cb33248
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
r=me if you decide to submit as is. |
@nikomatsakis This looks good to me and I think the new type helps improve the documentation. |
@bors r+ |
📌 Commit c63b633 has been approved by |
@bors p=1 Part of Edition |
fix for late-bound regions Fix for #53419 r? @nikomatsakis
☀️ Test successful - status-appveyor, status-travis |
Fix for #53419
r? @nikomatsakis