Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for late-bound regions #53441

Merged
merged 5 commits into from
Aug 27, 2018
Merged

fix for late-bound regions #53441

merged 5 commits into from
Aug 27, 2018

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Aug 17, 2018

Fix for #53419

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2018
@estebank
Copy link
Contributor

This seems reasonable, but I'm intrigued if this could introduce potential bugs...

@nikomatsakis
Copy link
Contributor

Sorry for the delay. Rust conf. This doesn't feel quite right to me, but let me investigate the code and say a bit more =)

@nikomatsakis
Copy link
Contributor

OK, I see now where the assert is failing. I pushed a commit that fixes this in a different way -- basically, doing a better job of the previous hack. If you recall, @toidiu, we already modified the code to just ignore Self since it was unknown -- we were using ty as a "convenient self type", but it turns out that was a bad choice. Since it doesn't really matter what type we use, I modified the code to just use usize, which will obviously not trip that assert.

I also added a newtype for the bool to make it a bit more self documenting. Weird quirk I have.

What do you think?

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@estebank
Copy link
Contributor

r=me if you decide to submit as is.

@toidiu
Copy link
Contributor Author

toidiu commented Aug 27, 2018

@nikomatsakis This looks good to me and I think the new type helps improve the documentation.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 27, 2018

📌 Commit c63b633 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2018
@nikomatsakis
Copy link
Contributor

@bors p=1

Part of Edition

@bors
Copy link
Contributor

bors commented Aug 27, 2018

⌛ Testing commit c63b633 with merge 70a21e8...

bors added a commit that referenced this pull request Aug 27, 2018
@bors
Copy link
Contributor

bors commented Aug 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 70a21e8 to master...

@bors bors merged commit c63b633 into rust-lang:master Aug 27, 2018
@toidiu toidiu deleted the ak-fix53419 branch August 27, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants