Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo #54342

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Update Cargo #54342

merged 1 commit into from
Sep 19, 2018

Conversation

steveklabnik
Copy link
Member

This pulls in rust-lang/cargo#6054, and
is a beta backport of #54334

This pulls in rust-lang/cargo#6054, and
is a beta backport of rust-lang#54334
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2018
@steveklabnik steveklabnik mentioned this pull request Sep 19, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1 because edition priority

@bors
Copy link
Contributor

bors commented Sep 19, 2018

📌 Commit 889ab28 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2018
@Mark-Simulacrum
Copy link
Member

Actually, I think this might run into the same problem as the other pull request in that it doesn't update cargo.lock? Travis seems to be going though so maybe beta didn't need it.

@ehuss
Copy link
Contributor

ehuss commented Sep 19, 2018

This removes about 4 days of updates that were in 1.30. Not sure how important that is. The rust beta branch was pointing at a5d82949485802abb45f888d5b8b7f23927f031d of cargo's master (from Sep 13). The cargo-1.30.0 was branched off from b917e35248fe57d11765c5a835de33e335babb7e from Sep 9th. I don't know why the 1.30.0 branch was so far back. Here's the diff: rust-lang/cargo@b917e35...a5d8294

@bors
Copy link
Contributor

bors commented Sep 19, 2018

⌛ Testing commit 889ab28 with merge c5a2e4239ca0d4b9bef5dcfdb62249f1a8662ed6...

@bors
Copy link
Contributor

bors commented Sep 19, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2018
@rust-highfive
Copy link
Collaborator

The job dist-i586-gnu-i586-i686-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:37:07] Build completed successfully in 1:32:25
[01:37:07] + python2.7 ../x.py dist --target i586-unknown-linux-gnu,i686-unknown-linux-musl,i586-unknown-linux-musl
[01:37:07]     Finished dev [unoptimized] target(s) in 0.26s
[01:37:28] fatal: unable to access 'https://github.com/rust-lang/rust.git/': Could not resolve host: github.com
[01:37:28] thread 'main' panicked at 'command did not execute successfully: "git" "ls-remote" "origin" "beta"
[01:37:28] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:37:28] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --target i586-unknown-linux-gnu,i686-unknown-linux-musl,i586-unknown-linux-musl
[01:37:28] Build completed unsuccessfully in 0:00:21
travis_time:end:1ab00596:start=1537334197980408234,finish=1537340047008730856,duration=5849028322622
---
travis_time:end:059f0cca:start=1537340048621225390,finish=1537340048625452341,duration=4226951
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2b6b835e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0077e707
travis_time:start:0077e707
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0b1beb60
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@steveklabnik
Copy link
Member Author

I think this might run into the same problem as the other pull request in that it doesn't update cargo.lock?

I ran cargo update cargo -p and it didn't change anything.

This removes about 4 days of updates that were in 1.30. Not sure how important that is.

I'm not sure either; this was the path Alex told me to take. I think it's because it has to be before the version bump PR landed. None of that diff looks mega-important to me, so I think it's fine.

@steveklabnik
Copy link
Member Author

[01:37:28] fatal: unable to access 'https://github.com/rust-lang/rust.git/': Could not resolve host: github.com

Seems spurious.

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2018
@bors
Copy link
Contributor

bors commented Sep 19, 2018

⌛ Testing commit 889ab28 with merge 7a0062e...

bors added a commit that referenced this pull request Sep 19, 2018
@bors
Copy link
Contributor

bors commented Sep 19, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 7a0062e to beta...

@bors bors merged commit 889ab28 into rust-lang:beta Sep 19, 2018
@ehuss
Copy link
Contributor

ehuss commented Sep 19, 2018

I think it's because it has to be before the version bump PR landed. None of that diff looks mega-important to me, so I think it's fine.

The version bump was done on the 18th (after the beta branch). This has happened in the past, and @alexcrichton just fixed the branch. Personally I'd be a little disappointed if the new progress bar took another 6 weeks to be stabilized, but it's not critical.

@steveklabnik steveklabnik deleted the update-cargo-beta branch September 19, 2018 17:16
@alexcrichton
Copy link
Member

Er sorry, it appears I botched the original base of the rust-1.30.0 branch! I'll fix that.

bors added a commit to rust-lang/cargo that referenced this pull request Sep 19, 2018
[beta]: Fixup the 1.30.0 branch

Reconciles data found in this comment rust-lang/rust#54342 (comment) by merging the cargo submodule's commit of the original beta for 1.30.0 into the current 1.30.0 branch.

Includes stabilization of `-Z compile-progress` as well as a number of other nice fixes!

r? @ehuss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants