Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize disable-minification option #54827

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2018
@Centril Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 6, 2018
@QuietMisdreavus
Copy link
Member

cc @rust-lang/rustdoc

This is effectively a debugging flag, right? Has this flag received any major use? Are there any tests for this flag? (I'm curious how those would look...) Does the Rustdoc Book have any documentation about this flag? (We'll need to move it into the stable section, if so.)

@GuillaumeGomez
Copy link
Member Author

Yes, yes (well, for me at least), no (not sure how to test it...), no idea.

@QuietMisdreavus
Copy link
Member

I don't see anything on https://doc.rust-lang.org/nightly/rustdoc/unstable-features.html about this flag, so i assume that it has no docs. Can you add a section to the "Command-line arguments" page about this flag?

To test, it depends on whether the minification will remove certain whitespace entirely. If so, we can use a regular rustdoc test to ensure that the minified version has some portion of a JS/CSS file with no whitespace in some location, and the non-minified version preserved that whitespace. (It's problematic because apparently htmldocck.py collapses whitespace too, so it's hard to check. >_>) Alternately, you could do a run-make test which runs docs on some sample crate twice, and compares main.js in each one to make sure they don't have the same file content.

@TimNN TimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2018
@TimNN
Copy link
Contributor

TimNN commented Nov 13, 2018

Ping from triage @GuillaumeGomez: What is the status of this PR?

@GuillaumeGomez
Copy link
Member Author

I need to add the documentation.

@TimNN
Copy link
Contributor

TimNN commented Nov 20, 2018

Ping from triage @GuillaumeGomez: Do you think you'll be able to / have the time to continue working on this PR?

@GuillaumeGomez
Copy link
Member Author

Yup yup.

@TimNN
Copy link
Contributor

TimNN commented Nov 27, 2018

Ping from triage! This PR hasn't made any progress in a while, so I'm closing it for now. Thanks for your contributions and please feel free to re-open in the future.

@TimNN TimNN closed this Nov 27, 2018
@TimNN TimNN added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants