-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize disable-minification option #54827
Stabilize disable-minification option #54827
Conversation
cc @rust-lang/rustdoc This is effectively a debugging flag, right? Has this flag received any major use? Are there any tests for this flag? (I'm curious how those would look...) Does the Rustdoc Book have any documentation about this flag? (We'll need to move it into the stable section, if so.) |
Yes, yes (well, for me at least), no (not sure how to test it...), no idea. |
I don't see anything on https://doc.rust-lang.org/nightly/rustdoc/unstable-features.html about this flag, so i assume that it has no docs. Can you add a section to the "Command-line arguments" page about this flag? To test, it depends on whether the minification will remove certain whitespace entirely. If so, we can use a regular rustdoc test to ensure that the minified version has some portion of a JS/CSS file with no whitespace in some location, and the non-minified version preserved that whitespace. (It's problematic because apparently |
Ping from triage @GuillaumeGomez: What is the status of this PR? |
I need to add the documentation. |
Ping from triage @GuillaumeGomez: Do you think you'll be able to / have the time to continue working on this PR? |
Yup yup. |
Ping from triage! This PR hasn't made any progress in a while, so I'm closing it for now. Thanks for your contributions and please feel free to re-open in the future. |
Fixes #54819.
r? @QuietMisdreavus