-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move collect_and_partition_mono_items to rustc_mir #55349
Move collect_and_partition_mono_items to rustc_mir #55349
Conversation
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with nit fixed
@bors r+ |
📌 Commit adafd0f has been approved by |
Should I close #55225? |
idk what the rules are. These PRs are probably going to get rolled up anyway |
Will close it, so that the first commit doesn't get included twice (that commit is a rebase of the other pr) |
…ion_mono_items, r=oli-obk Move collect_and_partition_mono_items to rustc_mir Most of the logic of it is inside rustc_mir anyway. Also removes the single function crate rustc_metadata_utils. Based on rust-lang#55225
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #55238) made this pull request unmergeable. Please resolve the merge conflicts. |
adafd0f
to
c859919
Compare
Rebased |
Co-Authored-By: bjorn3 <[email protected]>
@bors r+ |
📌 Commit 9e479c2 has been approved by |
…ems, r=oli-obk Move collect_and_partition_mono_items to rustc_mir Most of the logic of it is inside rustc_mir anyway. Also removes the single function crate rustc_metadata_utils. Based on #55225
☀️ Test successful - status-appveyor, status-travis |
Most of the logic of it is inside rustc_mir anyway.
Also removes the single function crate rustc_metadata_utils. Based on #55225