rustdoc: refactor: centralize all command-line argument parsing #55515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
QuietMisdreavus
force-pushed
the
rustdoc-config
branch
from
324bd87 to
e1c04af
Compare
|
That simplifies the code a lot! r=me once CI passed. |
fbstj
reviewed
Oct 30, 2018
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r=GuillaumeGomez |
|
📌 Commit bdb8cb4553f914134e57c73197f3b34aa8ac14a6 has been approved by |
bors
added
the
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #54543) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
QuietMisdreavus
force-pushed
the
rustdoc-config
branch
from
bdb8cb4 to
297cfea
Compare
|
Well that was an intense rebase. @GuillaumeGomez can you take another look? I had to change around |
QuietMisdreavus
added
S-waiting-on-review
| for &flag in removed_flags.iter() { | ||
| if matches.opt_present(flag) { | ||
| diag.struct_warn(&format!("the '{}' flag no longer functions", flag)) | ||
| .warn("see CVE-2018-1000622") |
There was a problem hiding this comment.
All removed flags are linked to this CVE?
There was a problem hiding this comment.
Both of these flags are, yes. They showed a similar message that was printed with eprintln!(), which was being checked in rust_input.
|
Updated! |
|
Thanks! @bors: r+ |
|
📌 Commit 560a01c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 5, 2018
rustdoc: refactor: centralize all command-line argument parsing This is something i've wanted to do for a while, since we keep having to add new arguments to places like `rust_input` or `core::run_core` whenever we add a new CLI flag or the like. Those functions have inflated up to 11-19, and in some cases hiding away the locations where some CLI flags were being parsed, obscuring their use. Now, we have a central place where all command-line configuration occurs, including argument validation. One note about the design: i grouped together all the arguments that `html::render::run` needed, so that i could pass them on from compilation in one lump instead of trying to thread through individual items or clone the entire blob ahead of time. One other thing this adds is that rustdoc also now recognizes all the `-Z` options that rustc does, since we were manually grabbing a few previously. Now we parse a full `DebuggingOptions` struct and hand it directly to rustc when scraping docs.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something i've wanted to do for a while, since we keep having to add new arguments to places like
rust_inputorcore::run_corewhenever we add a new CLI flag or the like. Those functions have inflated up to 11-19, and in some cases hiding away the locations where some CLI flags were being parsed, obscuring their use. Now, we have a central place where all command-line configuration occurs, including argument validation.One note about the design: i grouped together all the arguments that
html::render::runneeded, so that i could pass them on from compilation in one lump instead of trying to thread through individual items or clone the entire blob ahead of time.One other thing this adds is that rustdoc also now recognizes all the
-Zoptions that rustc does, since we were manually grabbing a few previously. Now we parse a fullDebuggingOptionsstruct and hand it directly to rustc when scraping docs.