Code

Value visitors for miri#55549

Code

Merged

bors merged 21 commits intorust-lang:masterrust-lang/rust:masterfrom RalfJung:miri-visitorRalfJung/rust:miri-visitorCopy head branch name to clipboardNov 7, 2018

+786-439

Commits

Commits on Nov 5, 2018

• generalize the traversal part of validation to a ValueVisitor

  RalfJung

  committed
  5b5e076

  Copy full SHA for 5b5e076

• reduce the amount of traversal/projection code that the visitor has to implement itself

  RalfJung

  committed
  7d7bd9b

  Copy full SHA for 7d7bd9b

• also allow visiting places and mplaces

  RalfJung

  committed
  c8e471f

  Copy full SHA for c8e471f

• fix for pre-NLL rustc

  RalfJung

  committed
  fdc3a3e

  Copy full SHA for fdc3a3e

• add visit() hook to the trait

  RalfJung

  committed
  33770ab

  Copy full SHA for 33770ab

• provide some default implementations

  RalfJung

  committed
  b0f1b1a

  Copy full SHA for b0f1b1a

• let the Value handle enum projections, so the visitor does not have to care

  RalfJung

  committed
  6d24b37

  Copy full SHA for 6d24b37

• fix validation error on non-integer enum discriminants

  RalfJung

  committed
  fa01e04

  Copy full SHA for fa01e04

• Also test for undef in enum discriminant

  Show description for 77c2834
  RalfJung

  committed
  77c2834

  Copy full SHA for 77c2834

• converting a VisitorValue to a MemPlace must not mutate anything

  RalfJung

  committed
  aea61e3

  Copy full SHA for aea61e3

• use more traditional walk_array/visit_array instead of the handle_array hook

  RalfJung

  committed
  98295e9

  Copy full SHA for 98295e9

• finally this actually looks like a visitor

  RalfJung

  committed
  b096f08

  Copy full SHA for b096f08

• all values can convert to operators

  RalfJung

  committed
  c267721

  Copy full SHA for c267721

• the visitor can already load the value for visit_primitive

  RalfJung

  committed
  996a425

  Copy full SHA for 996a425

• visit_aggregate with an iterator; fix some comment typos

  RalfJung

  committed
  91cad39

  Copy full SHA for 91cad39

• FIXME

  RalfJung

  committed
  0d596f2

  Copy full SHA for 0d596f2

• machine hooks for ptr (de)ref also need layout, and then they do not need the size

  RalfJung

  committed
  7565b5a

  Copy full SHA for 7565b5a

• make ValueVisitor mut-polymorphic

  RalfJung

  committed
  8730410

  Copy full SHA for 8730410

• proide ptr_wrapping_offset on Scalars

  RalfJung

  committed
  0529dc8

  Copy full SHA for 0529dc8

• walk_value: more tracing

  RalfJung

  committed
  a0074ca

  Copy full SHA for a0074ca

• add method to obtain the ptr offset of a Scalar

  RalfJung

  committed
  7b7c6ce

  Copy full SHA for 7b7c6ce