-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a bare-bones eslint config (removing jslint) #56523
Conversation
This change removes the small bit of jslint config, replacing it with eslint. I've currently configured eslint to mostly only report the more serious of lints, although there are still some style nits turned on. Upcoming changes will start fixing lints.
Some changes occurred in HTML/CSS. |
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Thanks! For the other changes, please wait for #56005 to be merged first. |
@bors: r+ rollup |
📌 Commit 5d7cf59 has been approved by |
Added a bare-bones eslint config (removing jslint) This change removes the small bit of jslint config, replacing it with eslint. I've currently configured eslint to mostly only report the more serious of lints, although there are still some style nits turned on. Eslint better supports modern js, and will be a good pre-TypeScript code quality aid. Install eslint with `npm install -g eslint`. Run with `eslint html/static/*.js`, or let your IDE do it. This requires no build step. Upcoming changes will start fixing identified bugs and other lints (mostly unused and var redef issues).
Added a bare-bones eslint config (removing jslint) This change removes the small bit of jslint config, replacing it with eslint. I've currently configured eslint to mostly only report the more serious of lints, although there are still some style nits turned on. Eslint better supports modern js, and will be a good pre-TypeScript code quality aid. Install eslint with `npm install -g eslint`. Run with `eslint html/static/*.js`, or let your IDE do it. This requires no build step. Upcoming changes will start fixing identified bugs and other lints (mostly unused and var redef issues).
Added a bare-bones eslint config (removing jslint) This change removes the small bit of jslint config, replacing it with eslint. I've currently configured eslint to mostly only report the more serious of lints, although there are still some style nits turned on. Eslint better supports modern js, and will be a good pre-TypeScript code quality aid. Install eslint with `npm install -g eslint`. Run with `eslint html/static/*.js`, or let your IDE do it. This requires no build step. Upcoming changes will start fixing identified bugs and other lints (mostly unused and var redef issues).
Rollup of 15 pull requests Successful merges: - #51753 (Document `From` implementations) - #55563 (Improve no result found sentence in doc search) - #55987 (Add Weak.ptr_eq) - #56119 (Utilize `?` instead of `return None`.) - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs) - #56388 (More MIR borrow check cleanup) - #56424 (Mention raw-ident syntax) - #56452 (Remove redundant clones) - #56456 (Handle existential types in dead code analysis) - #56466 (data_structures: remove tuple_slice) - #56476 (Fix invalid line number match) - #56497 (cleanup: remove static lifetimes from consts in libstd) - #56498 (Fix line numbers display) - #56523 (Added a bare-bones eslint config (removing jslint)) - #56538 (Use inner iterator may_have_side_effect for Cloned) Failed merges: r? @ghost
This change removes the small bit of jslint config, replacing it
with eslint. I've currently configured eslint to mostly only report
the more serious of lints, although there are still some style nits
turned on.
Eslint better supports modern js, and will be a good pre-TypeScript code
quality aid.
Install eslint with
npm install -g eslint
. Run witheslint html/static/*.js
,or let your IDE do it. This requires no build step.
Upcoming changes will start fixing identified bugs and other lints (mostly unused and var redef issues).