Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code being shown after line numbers #56529

Closed
wants to merge 1 commit into from
Closed

Fix code being shown after line numbers #56529

wants to merge 1 commit into from

Conversation

Walther
Copy link

@Walther Walther commented Dec 5, 2018

Fixes #56526

Before:
screen shot 2018-12-04 at 20 38 13

After:
screen shot 2018-12-04 at 21 35 23

screen shot 2018-12-04 at 21 47 38

Fun sidenote: building the docs with the README instructions ./x.py doc compiles the entire rustc, which takes a moment 😄

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 5, 2018
@GuillaumeGomez
Copy link
Member

Another PR is already open to fix this (#56498) so I'll close this one. Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants