Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove single-variant Guard enums. #58283

Closed
wants to merge 1 commit into from

Conversation

nnethercote
Copy link
Contributor

They're not useful.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2019
@nnethercote nnethercote closed this Feb 8, 2019
@nnethercote nnethercote reopened this Feb 8, 2019
@petrochenkov
Copy link
Contributor

cc @F001
The enum was introduced in #53815 as a "first step to implement RFC 2294: if-let-guard".

Citing my comment there:

My only concern is that there's pretty long road between adding if-let guards into AST/HIR and making them actually work, so this might stay as dead code for some time.

@nnethercote
Copy link
Contributor Author

I see. I will change this PR so it just adds a comment on the types explaining why they exist.

@bors
Copy link
Contributor

bors commented Feb 9, 2019

☔ The latest upstream changes (presumably #58316) made this pull request unmergeable. Please resolve the merge conflicts.

@nnethercote nnethercote deleted the rm-Guard branch February 14, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants