-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore should_panic tests on android #58900
Ignore should_panic tests on android #58900
Conversation
r? @kennytm |
I will also note that I have not tested that this code works locally beyond "it compiles" but it looks like it should do what we want it to. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after fixing tidy.
These tests currently segfault sometimes. Android is a tier-2 target so this is fine to disable instead of fixing. Unfortunately, this isn't quite enough as rustdoc doesn't currently correctly interpret the --exclude-should-panic flag (i.e., ignores it). That proved to be harder to fix than I had time for so we're going to leave it and hope that at least some of the failures are fixed.
e34d45b
to
1055263
Compare
@bors r=kennytm |
📌 Commit 1055263 has been approved by |
…-android, r=kennytm Ignore should_panic tests on android These tests currently segfault sometimes. Android is a tier-2 target so this is fine to disable instead of fixing. Unfortunately, this isn't quite enough as rustdoc doesn't currently correctly interpret the --exclude-should-panic flag (i.e., ignores it). That proved to be harder to fix than I had time for so we're going to leave it and hope that at least some of the failures are fixed. Hopefully alleviates rust-lang#55861; I don't have the time to investigate fixing rustdoc.
Probably failed in #59043 (comment), @bors r- |
We don't need |
I suspect it's being passed to the wrong tool. I'll try to investigate further today. |
Ping from triage @Mark-Simulacrum: What is the status of this PR? |
I will try to get back to this sometime this week. |
I don't think I'll have the time soon to take this on unfortunately so I'm going to close this. |
These tests currently segfault sometimes. Android is a tier-2 target so
this is fine to disable instead of fixing.
Unfortunately, this isn't quite enough as rustdoc doesn't currently
correctly interpret the --exclude-should-panic flag (i.e., ignores it).
That proved to be harder to fix than I had time for so we're going to
leave it and hope that at least some of the failures are fixed.
Hopefully alleviates #55861; I don't have the time to investigate fixing rustdoc.