submodules: update clippy, rls and miri #59810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: ```` Remove force-host and explain no-prefer-dynamic Escape a single quote in single_char_pattern hint cargo fmt Re-add tmp feature to compiletest Remove libtest from deps Re-allow clippy::identity_conversion in compiletest Use latest compiletest-rs Revert tests/compile-test.rs to 61aa5c9 Fix ICE in suspicious_else_formatting use a multispan for MANY_SINGLE_CHAR_NAMES Add missing `// run-pass` annotations to ICE tests Remove clippy_dev as dev-dependency NFC: fix typos rustup rust-lang#59657 Add TransmutingNull Lint * Late Lint pass, catches: * One liner: 0 -> null -> transmute * One liner: std:null() -> transmute * Const (which resolves to null) -> transmute * UI Test case for Lint * Updated test for issue 3849, because now the lint that code generated is in Clippy. * Expanded `const.rs` miri-based Constant Folding code, to cover raw pointers Run rustfmt Set level of identity_conversion FP to warn Rustup to rust-lang#58805 rustup 41316f0 Updated source to match with recent rustc `master` toolchain changes Fix dogfood error of question_mark lint fix Fix question_mark lint+test use `span_lint_and_sugg` in `explicit_counter_loop` Fix some test failures Hacky rustup run cargo fmt rustup rust-lang#59096 Change explicit_counter_loop's message to add parentheses if necessary Change explicit_counter_loop's message to reflect original variable name cargo fmt Add rustfix tests for mistyped_literal_suffix lint Move some `unreadable_literal` ui tests to correct file Add implementation for the EarlyLintPass trait into the Adding Lints documentation. Add rust-toolchain for clippy_dev ````
Changes: ```` Update src/fn_call.rs Fix calloc test Add calloc test Tidy up calloc code Update compiletest Fix tagging order Add `calloc` rename MIRI_TARGET -> MIRI_COMPILETEST_TARGET to clarify that this affects compiletest only compiletest can just propagate MIRI_SYSROOT from the outside ````
Changes: ```` Account for changed format range in a test Adapt format integration test to use new range Add unit tests for Rustfmt::calc_text_edits Prefer saturating_sub Return only partial text edits on formatting request Redo errors in format.rs Rephrase unstable features helper function Work around Rustfmt bug Adjust range-formatting test Update Rustfmt to 1.2 Allow unstable features under "dev" channel Updated clippy_lints in to rev c81e43b to fix build breaking Fix lint pass API changes Remove a redundant import Bump Clippy Add more helpful compiler messages when the features are improperly specified Silence some flaky tests. Update Cargo. Rename read_analysis to decode_buf Update Clippy Fix pointer to pointer silliness Add serde implementation to complement rustc-serialize ````
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=1 |
|
📌 Commit beeeb43 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit beeeb43 with merge b5b4f07afabcf3416315f9b27561bf1db83dbd36... |
Closed
Closed
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
This didn't happen when I tested locally, hmm. |
|
@bors retry |
bors
added
S-waiting-on-bors
|
Yeah, that's a spurious RLS error I have seen before. Is there an issue for it? |
|
@bors p=20 |
bors
added a commit
that referenced
this pull request
Apr 9, 2019
submodules: update clippy, rls and miri Let's give this another try. r? @Manishearth cc @Xanewok
|
💔 Test failed - checks-travis |
|
Merging manually is not an option, right? :/ |
|
Nope, release artifacts (also used for nightly) are uploaded after the build, and if we merge before all the builders finish we're going to miss macOS, which is unacceptable since it's a Tier 1 platform. I'm going to stop retrying until Travis replies to me (pinged them again a few minutes ago) as we keep getting scheduled on the same builder. No point spamming y'all with all the retries. |
|
💔 Test failed - checks-travis |
bors
removed
the
S-waiting-on-bors
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
the
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit beeeb43 with merge bf61ab559c56ca480dd7003afb3ccde33a3c2408... |
|
@bors retry |
|
⌛ Testing commit beeeb43 with merge ef662ae02b3753f9575a181e448ebfc57042431c... |
|
Currently, all four apple builds are more or less even in time. Both |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Apr 10, 2019
submodules: update clippy, rls and miri Let's give this another try. r? @Manishearth cc @Xanewok
|
☀️ Test successful - checks-travis, status-appveyor |
|
📣 Toolstate changed by #59810! Tested on commit 96d700f. 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 10, 2019
Tested on commit rust-lang/rust@96d700f. Direct link to PR: <rust-lang/rust#59810> 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra). 🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
This was referenced Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's give this another try.
r? @Manishearth
cc @Xanewok