-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make std::fs::copy
attempt to create copy-on-write clones of files on MacOS
#59883
Conversation
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
r? @sfackler |
@bors r+ |
📌 Commit df738ac has been approved by |
Make `std::fs::copy` attempt to create copy-on-write clones of files on MacOS The behaviour of MacOS now matches Linux which uses `copy_file_range` to perform CoW file copies where available and supported by the underlying filesystem.
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
I don't understand the failure. It looks completely unrelated to this PR but it happened only on an Apple builder. The linker |
@sfackler I can't reproduce this locally (after a rebase so I should be testing the same thing as bors). I think it's probably spurious. Could you re r+?. |
@bors r+ |
📌 Commit 0fd446e has been approved by |
Make `std::fs::copy` attempt to create copy-on-write clones of files on MacOS The behaviour of MacOS now matches Linux which uses `copy_file_range` to perform CoW file copies where available and supported by the underlying filesystem.
☀️ Test successful - checks-travis, status-appveyor |
The behaviour of MacOS now matches Linux which uses
copy_file_range
to perform CoW file copies where available and supported by the underlying filesystem.