Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std #59908

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std #59908

merged 1 commit into from
Apr 18, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Apr 12, 2019 •
edited
Loading

cc #59893

@rust-highfive
Copy link
Collaborator

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Apr 12, 2019

r? @Mark-Simulacrum
@rustbot modify labels: +T-libs.

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 12, 2019
@pietroalbini
Copy link
Member

cc @rust-lang/release
@rustbot modify labels: beta-nominated and stable-nominated.

@rustbot rustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Apr 12, 2019
@SimonSapin
Copy link
Contributor

@pietroalbini what does stable-nominated mean? This change is low-risk, but definitely not worth making a 1.34.1 release on its own. (Unlike NonZeroI32 and friends, typical usage of these types does not require naming them: they are return types for inherent methods of str.)

@pietroalbini
Copy link
Member

Yep, it's not worth making a point release on its own, but there are also two beta regression ICEs that slipped in 1.34.0. The release team will decide if it's worth making a point release with this change and the two fixes in the meeting today (20:00 UTC, #release on discord).

@pietroalbini
Copy link
Member

@rust-lang/libs the release team agreed to release 1.34.1 on Thursday 25th, do you think this PR is safe to backport?

@SimonSapin
Copy link
Contributor

Yes I would call it safe. But also of only small benefit in extremely niche situations.

@SimonSapin
Copy link
Contributor

The libs team accepted backporting to beta in today’s triage meeting. However we feel that including this in the 1.34.1 release and in the accompanying blog post seems excessive, it’s not worth so much attention.

@SimonSapin SimonSapin added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed stable-nominated Nominated for backporting to the compiler in the stable channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 17, 2019
@SimonSapin
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2019

📌 Commit 2545867 has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2019
@bors
Copy link
Contributor

bors commented Apr 17, 2019

⌛ Testing commit 2545867 with merge 318cb64ea956093c50811a64423a112062587e3f...

Centril added a commit to Centril/rust that referenced this pull request Apr 17, 2019
@Centril
Rollup merge of rust-lang#59908 - lzutao:str_escape, r=SimonSapin
a204387 
Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std

cc rust-lang#59893
@Centril Centril mentioned this pull request Apr 17, 2019
Merged
@Centril
Copy link
Contributor

Centril commented Apr 17, 2019

@bors retry

bors added a commit that referenced this pull request Apr 17, 2019
@bors
Auto merge of #60054 - Centril:rollup-o40xxaa, r=Centril
9387927 
Rollup of 4 pull requests

Successful merges:

 - #59908 (Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std)
 - #59984 (Remove collection-specific `with_capacity` documentation from `std::collections`)
 - #60036 (Remove nrc from toolstate pings)
 - #60037 (Resolve inconsistency in error messages between "parameter" and "variable".)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Apr 18, 2019

⌛ Testing commit 2545867 with merge 9387927...

@bors bors merged commit 2545867 into rust-lang:master Apr 18, 2019
@tesuji tesuji deleted the str_escape branch April 18, 2019 06:48
@camelid camelid mentioned this pull request Sep 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tesuji @rust-highfive @pietroalbini @SimonSapin @bors @Centril @aidanhs @Mark-Simulacrum @rustbot