stable hashing: Remove unused field and add documentation. #60915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
fbstj
reviewed
May 17, 2019
| /// That second condition is usually not required for hash functions | ||
| /// (e.g. `Hash`). In practice this means that `hash_stable` must feed any | ||
| /// information into the hasher that a `PartialEq` comparision takes into | ||
| /// account. See #49300 for an example where violating this invariant has |
There was a problem hiding this comment.
Suggested change
| /// account. See #49300 for an example where violating this invariant has | |
| /// account. See [#49300](https://github.com/rust-lang/rust/issues/49300) for an example where violating this invariant has |
|
Other than the link for the sake of https://doc.rust-lang.org/nightly/nightly-rustc/rustc_data_structures/stable_hasher/trait.HashStable.html, r=me |
michaelwoerister
force-pushed
the
hashstablestuff
branch
from
f2453c2 to
a79c06a
Compare
|
I updated the link. |
|
📌 Commit a79c06a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 20, 2019
…=estebank stable hashing: Remove unused field and add documentation. This PR removes the `bytes_hashed` field from `StableHasher` which in the past has been used for collecting some statistics but has gone unused for quite a while (months at least) now. The PR also tries to document some requirements for `HashStable` implementations that haven't been written down explicitly anywhere.
bors
added a commit
that referenced
this pull request
May 20, 2019
Rollup of 11 pull requests Successful merges: - #60383 (Fix position source code files toggle) - #60453 (Fall back to `/dev/urandom` on `EPERM` for `getrandom`) - #60487 (Fix search sidebar width when no crate select is present) - #60511 (Fix intra-doc link resolution failure on re-exporting libstd) - #60823 (Fix incremental compilation of cdylib emitting spurious unused_attributes lint) - #60915 (stable hashing: Remove unused field and add documentation.) - #60942 (Misc changes to rustc_metadata) - #60952 (Document BinaryHeap time complexity) - #60959 (rustc: Improve type size assertions) - #60972 (remove confusing remarks about mixed volatile and non-volatile accesses) - #60983 (Set -funwind-tables and -fno-exceptions unconditionally for LLVM's libunwind) Failed merges: r? @ghost
|
☔ The latest upstream changes (presumably #60986) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
bytes_hashedfield fromStableHasherwhich in the past has been used for collecting some statistics but has gone unused for quite a while (months at least) now.The PR also tries to document some requirements for
HashStableimplementations that haven't been written down explicitly anywhere.