Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded feature attr from atomic integers doctests #61453

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Remove unneeded feature attr from atomic integers doctests #61453

merged 1 commit into from
Jun 5, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 2, 2019

Closes #61448

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2019
@tesuji

This comment has been minimized.

Sign in to view
@rustbot rustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jun 2, 2019
@tesuji

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 2, 2019

@lzutao: 🔑 Insufficient privileges: not in try users

@Centril
Copy link
Contributor

Centril commented Jun 2, 2019

r? @sfackler

@rust-highfive rust-highfive assigned sfackler and unassigned Centril Jun 2, 2019
@sfackler
Copy link
Member

sfackler commented Jun 2, 2019

Where else is $extra_feature used? It seems like it can be removed entirely from the macro, right?

@tesuji
Copy link
Contributor Author

tesuji commented Jun 2, 2019

I was thinking that #![feature(integer_atomics)] still be used in unstable
Atomic integers (for example: https://doc.rust-lang.org/nightly/std/sync/atomic/struct.AtomicU8.html#method.fetch_min). Looks like I am wrong:
https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=6da6afeaf1fe1a4f018682886a0c39d4

@tesuji tesuji force-pushed the nouse-featuregate-integer_atomics branch 2 times, most recently from f256ebd to 90d8781 Compare June 2, 2019 15:10
@tesuji
Copy link
Contributor Author

tesuji commented Jun 2, 2019

AtomicU128 and AtomicI128 are unstable and need $extra_feature in doctest.
Should I keep it? @sfackler

@sfackler
Copy link
Member

sfackler commented Jun 2, 2019

Oh, okay.

@tesuji tesuji force-pushed the nouse-featuregate-integer_atomics branch from 90d8781 to f60b5f1 Compare June 4, 2019 13:25
@tesuji
Copy link
Contributor Author

tesuji commented Jun 4, 2019

Ping @sfackler , this PR is ready to review again.

@sfackler
Copy link
Member

sfackler commented Jun 4, 2019

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Jun 4, 2019

📌 Commit f60b5f1 has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jun 4, 2019
@pietroalbini
Rollup merge of rust-lang#61453 - lzutao:nouse-featuregate-integer_at…
98176fc 
…omics, r=sfackler

Remove unneeded feature attr from atomic integers doctests

Closes rust-lang#61448

r? @Centril
@pietroalbini pietroalbini mentioned this pull request Jun 4, 2019
Merged
bors added a commit that referenced this pull request Jun 4, 2019
@bors
Auto merge of #61527 - pietroalbini:rollup-vhxyqlk, r=pietroalbini
81eb152 
Rollup of 5 pull requests

Successful merges:

 - #61069 (Make MIR drop terminators borrow the dropped location)
 - #61453 (Remove unneeded feature attr from atomic integers doctests)
 - #61488 (Fix NLL typeck ICEs)
 - #61500 (Fix regression 61475)
 - #61523 (Hide gen_future API from documentation)

Failed merges:

r? @ghost
@bors bors merged commit f60b5f1 into rust-lang:master Jun 5, 2019
@tesuji tesuji deleted the nouse-featuregate-integer_atomics branch June 5, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature attribute can be removed from atomic integers doctests.
6 participants
@tesuji @bors @Centril @sfackler @rust-highfive @rustbot