Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update miri #62024

Merged
merged 1 commit into from
Jun 22, 2019
Merged

update miri #62024

merged 1 commit into from
Jun 22, 2019

Conversation

RalfJung
Copy link
Member

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Jun 21, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 21, 2019

📌 Commit e848ce3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2019
@bors
Copy link
Contributor

bors commented Jun 21, 2019

⌛ Testing commit e848ce3 with merge 6378c2ad2dd553aa81f3190dac64ae356f7055a0...

@bors
Copy link
Contributor

bors commented Jun 21, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

Spurious network failure.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 21, 2019
@Centril
Rollup merge of rust-lang#62024 - RalfJung:miri, r=oli-obk
1a63f53 
update miri

r? @oli-obk
@Centril Centril mentioned this pull request Jun 21, 2019
Closed
@bors
Copy link
Contributor

bors commented Jun 21, 2019

⌛ Testing commit e848ce3 with merge 45286926c2e64fea90e90031e8734bcbf23828d4...

@bors
Copy link
Contributor

bors commented Jun 21, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

Looks like... Miri stopped compiling?

[01:47:45] �[0m�[0m�[1m�[32m   Compiling�[0m miri v0.1.0 (/checkout/src/tools/miri)
[01:47:48] �[0m�[1m�[38;5;9merror[E0277]�[0m�[0m�[1m: the `?` operator can only be applied to values that implement `std::ops::Try`�[0m
[01:47:48] �[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0msrc/tools/miri/src/intrinsic.rs:506:29�[0m
[01:47:48] �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
[01:47:48] �[0m�[1m�[38;5;12m506�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m/�[0m�[0m �[0m�[0m                            this.memory_mut()�[0m
[01:47:48] �[0m�[1m�[38;5;12m507�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m                                .get_mut(ptr.alloc_id)?�[0m
[01:47:48] �[0m�[1m�[38;5;12m508�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m                                .mark_definedness(ptr, dest.layout.size, false)?;�[0m
[01:47:48] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m|�[0m�[0m                                                                                �[0m�[0m�[1m�[38;5;9m^�[0m
[01:47:48] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m|�[0m�[0m                                                                                �[0m�[0m�[1m�[38;5;12m|�[0m
[01:47:48] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m|�[0m�[0m                                                                                �[0m�[0m�[1m�[38;5;9mthe `?` operator cannot be applied to type `()`�[0m
[01:47:48] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m|________________________________________________________________________________�[0m�[0m�[1m�[38;5;12min this expansion of `desugaring of `?``�[0m
[01:47:48] �[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m                                                                                 �[0m�[0m�[1m�[38;5;12min this macro invocation�[0m
[01:47:48] �[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
[01:47:48] �[0m    �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mhelp�[0m�[0m: the trait `std::ops::Try` is not implemented for `()`�[0m
[01:47:48] �[0m    �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: required by `std::ops::Try::into_result`�[0m

@RalfJung RalfJung closed this Jun 22, 2019
@RalfJung RalfJung reopened this Jun 22, 2019
@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jun 22, 2019

📌 Commit a1e954e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2019
@bors
Copy link
Contributor

bors commented Jun 22, 2019

⌛ Testing commit a1e954e with merge d4d5d67...

bors added a commit that referenced this pull request Jun 22, 2019
@bors
Auto merge of #62024 - RalfJung:miri, r=oli-obk
d4d5d67 
update miri

r? @oli-obk
@bors
Copy link
Contributor

bors commented Jun 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing d4d5d67 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 22, 2019
@bors bors merged commit a1e954e into rust-lang:master Jun 22, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #62024!

Tested on commit d4d5d67.
Direct link to PR: #62024

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 22, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#62024!
064d7b7 
Tested on commit rust-lang/rust@d4d5d67.
Direct link to PR: <rust-lang/rust#62024>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @rust-highfive @oli-obk @bors