or-patterns: Uniformly use `PatKind::Or` in AST & Fix/Cleanup resolve#64111

Merged

bors merged 27 commits intorust-lang:masterfrom Centril:ast-only-patkind-or

Sep 6, 2019

+1,273-623

Commits on Sep 5, 2019

resolve: extract resolve_params.
Centril
committed
resolve: cleanup using with_rib, etc.
Centril
committed
resolve: simplify resolve_arm.
Centril
committed
resolve: extract try_resolve_as_non_binding.
Centril
committed
resolve: add type IdentMap<T> alias.
Centril
committed
resolve: move fresh_binding.
Centril
committed
resolve: move resolve_block to a better place.
Centril
committed
resolve: already-bound-check: account for or-patterns.
Centril
committed
resolve: revamp already-bound check -- fix some bugs.
Centril
committed
resolve: add tests for already-bound check.
Centril
committed
resolve: account for general or-patterns in consistency checking.
Centril
committed
resolve: add test for missing bindings in or-patterns.
Centril
committed
resolve: test binding mode consistency for or-patterns.
Centril
committed
resolve: test consistent or-patterns being allowed.
Centril
committed
or-patterns: syntax: simplify Arm.pats and ExprKind::Let.0.
Centril
committed
or-patterns: syntax: adjust visit and mut_visit.
Centril
committed
or-patterns: syntax: adjust parser removing a hack.
Centril
committed
or-patterns: syntax: adjust pretty printing.
Centril
committed
or-patterns: syntax: adjust derive, format, and building.
Centril
committed
or-patterns: adjust librustc_lint.
Centril
committed
or-patterns: adjust lowering of ast::Arm & ast::ExprKind::Let.
Centril
committed
resolve: merge resolve_pats and resolve_pattern_top.
Centril
committed
or-patterns: adjust save_analysis wrt. process_var_decl{_multi}.
Centril
committed
or-patterns: fix pprust-expr-roundtrip due to AST change.
Centril
committed
or-patterns: address review comments.
Centril
committed
resolve: bool -> enum PatBoundCtx
Centril
committed
or-patterns: fix fallout from #664128.
Centril
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

or-patterns: Uniformly use `PatKind::Or` in AST & Fix/Cleanup resolve#64111

Commits on Sep 5, 2019

resolve: extract `resolve_params`.

resolve: cleanup using `with_rib`, etc.

resolve: simplify `resolve_arm`.

resolve: extract `try_resolve_as_non_binding`.

resolve: add `type IdentMap<T>` alias.

resolve: move `fresh_binding`.

resolve: move `resolve_block` to a better place.

resolve: already-bound-check: account for or-patterns.

resolve: revamp already-bound check -- fix some bugs.

resolve: add tests for already-bound check.

resolve: account for general or-patterns in consistency checking.

resolve: add test for missing bindings in or-patterns.

resolve: test binding mode consistency for or-patterns.

resolve: test consistent or-patterns being allowed.

or-patterns: syntax: simplify `Arm.pats` and `ExprKind::Let.0`.

or-patterns: syntax: adjust `visit` and `mut_visit`.

or-patterns: syntax: adjust parser removing a hack.

or-patterns: syntax: adjust pretty printing.

or-patterns: syntax: adjust derive, format, and building.

or-patterns: adjust librustc_lint.

or-patterns: adjust lowering of `ast::Arm` & `ast::ExprKind::Let`.

resolve: merge `resolve_pats` and `resolve_pattern_top`.

or-patterns: adjust save_analysis wrt. `process_var_decl{_multi}`.

or-patterns: fix pprust-expr-roundtrip due to AST change.

or-patterns: address review comments.

resolve: bool -> enum PatBoundCtx

or-patterns: fix fallout from #664128.