WIP: remove compiler plugin API for syntax transformers #64665

matklad · 2019-09-21T19:16:12Z

cc: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Removing.20.60Register.3A.3Aregister_macro.60.20compiler.20extension.20point

Things to check:

make sure that servo doesn't break
fix unstable book

This role is full filled by proc-macros now

rust-highfive · 2019-09-21T19:16:15Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

matklad · 2019-09-21T19:16:28Z

r? @petrochenkov

petrochenkov · 2019-09-21T20:26:35Z

This doesn't remove the fundamental possibility to add syntactic plugins, only helper functions, so r=me after updating the docs/examples/etc.

matklad · 2019-09-21T20:31:47Z

This doesn't remove the fundamental possibility to add syntactic plugins

Hm, I am confused by this statement. register_syntax_extension is the only thing that writes to syntax_exts field, and it is being removed. the field is public, but plugin writers are not supposed to use it, so it does remove fundamental ability from plugin writers?

petrochenkov · 2019-09-21T20:34:26Z

the field is public

Well, that's what I meant.
If you have a plugin you still can migrate, technically.

rust-highfive · 2019-09-21T20:34:27Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-21T19:16:47.7364233Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-21T19:16:48.5947096Z ##[command]git config gc.auto 0
2019-09-21T19:16:48.5951862Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-21T19:16:48.5954107Z ##[command]git config --get-all http.proxy
2019-09-21T19:16:48.5958203Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64665/merge:refs/remotes/pull/64665/merge
---
2019-09-21T20:21:04.4559981Z .................................................................................................... 1500/9030
2019-09-21T20:21:10.5445574Z .................................................................................................... 1600/9030
2019-09-21T20:21:23.7159430Z .....................................................................i...............i.............. 1700/9030
2019-09-21T20:21:30.7170685Z .................................................................................................... 1800/9030
2019-09-21T20:21:46.3911309Z ............................................................iiiii................................... 1900/9030
2019-09-21T20:21:58.9085972Z .................................................................................................... 2100/9030
2019-09-21T20:22:01.4675743Z .................................................................................................... 2200/9030
2019-09-21T20:22:04.7276283Z .................................................................................................... 2300/9030
2019-09-21T20:22:13.3901784Z .................................................................................................... 2400/9030
---
2019-09-21T20:25:18.4405359Z ................................................i...............i................................... 4700/9030
2019-09-21T20:25:28.2615068Z .................................................................................................... 4800/9030
2019-09-21T20:25:37.2756987Z .................................................................................................... 4900/9030
2019-09-21T20:25:46.4394059Z .................................................................................................... 5000/9030
2019-09-21T20:25:54.5530594Z ..................................ii.ii............................................................. 5100/9030
2019-09-21T20:26:04.4036928Z .................................................................................................... 5300/9030
2019-09-21T20:26:15.5872745Z ..................................................................................................i. 5400/9030
2019-09-21T20:26:24.2208346Z .................................................................................................... 5500/9030
2019-09-21T20:26:29.3061393Z .................................................................................................... 5600/9030
2019-09-21T20:26:29.3061393Z .................................................................................................... 5600/9030
2019-09-21T20:26:40.5932569Z .............................................................................................ii...i. 5700/9030
2019-09-21T20:26:55.4468942Z .ii...........i..................................................................................... 5800/9030
2019-09-21T20:27:17.0932284Z .................................................................................................... 6000/9030
2019-09-21T20:27:24.7099984Z ...............................................................................................i..ii 6100/9030
2019-09-21T20:27:39.2921792Z .................................................................................................... 6200/9030
2019-09-21T20:27:53.3342608Z .................................................................................................... 6300/9030
---
2019-09-21T20:32:42.1058521Z  finished in 5.726
2019-09-21T20:32:42.1261046Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-21T20:32:42.3191845Z 
2019-09-21T20:32:42.3193511Z running 150 tests
2019-09-21T20:32:45.7310711Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-09-21T20:32:47.7673092Z ..iiii..............i.........iii.i.......ii......
2019-09-21T20:32:47.7673572Z 
2019-09-21T20:32:47.7678508Z  finished in 5.641
2019-09-21T20:32:47.7883939Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-21T20:32:47.9583624Z 
---
2019-09-21T20:32:50.0878688Z  finished in 2.299
2019-09-21T20:32:50.1086769Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-21T20:32:50.2627387Z 
2019-09-21T20:32:50.2628304Z running 9 tests
2019-09-21T20:32:50.2629233Z iiiiiiiii
2019-09-21T20:32:50.2630460Z 
2019-09-21T20:32:50.2630591Z  finished in 0.154
2019-09-21T20:32:50.8912820Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-21T20:32:50.8913012Z 
---
2019-09-21T20:33:08.8069922Z  finished in 18.520
2019-09-21T20:33:08.8293063Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-21T20:33:09.0021909Z 
2019-09-21T20:33:09.0022770Z running 123 tests
2019-09-21T20:33:33.1640074Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-21T20:33:37.8879838Z i.i.i......iii.i.....ii
2019-09-21T20:33:37.8900080Z 
2019-09-21T20:33:37.8907526Z  finished in 29.061
2019-09-21T20:33:37.8917998Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-21T20:33:37.8918339Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2019-09-21T20:33:37.8918339Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2019-09-21T20:33:37.9142301Z Check compiletest suite=ui-fulldeps mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-21T20:33:38.0834083Z 
2019-09-21T20:33:38.0834919Z running 69 tests
2019-09-21T20:34:21.2411139Z ..............F.......................................FFFFFF...F....thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-21T20:34:21.2413478Z .
2019-09-21T20:34:21.2413719Z failures:
2019-09-21T20:34:21.2413793Z 
2019-09-21T20:34:21.2416138Z ---- [ui] ui-fulldeps/gated-plugin.rs stdout ----
2019-09-21T20:34:21.2416138Z ---- [ui] ui-fulldeps/gated-plugin.rs stdout ----
2019-09-21T20:34:21.2416938Z 
2019-09-21T20:34:21.2417691Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-09-21T20:34:21.2418000Z status: exit code: 1
2019-09-21T20:34:21.2418987Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary"
2019-09-21T20:34:21.2420320Z ------------------------------------------
2019-09-21T20:34:21.2420535Z 
2019-09-21T20:34:21.2420862Z ------------------------------------------
2019-09-21T20:34:21.2421033Z stderr:
2019-09-21T20:34:21.2421033Z stderr:
2019-09-21T20:34:21.2421550Z ------------------------------------------
2019-09-21T20:34:21.2422074Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-09-21T20:34:21.2422549Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:19:9
2019-09-21T20:34:21.2422706Z    |
2019-09-21T20:34:21.2422841Z LL |     reg.register_syntax_extension(
2019-09-21T20:34:21.2423211Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-09-21T20:34:21.2423723Z error: aborting due to previous error
2019-09-21T20:34:21.2423837Z 
2019-09-21T20:34:21.2424346Z For more information about this error, try `rustc --explain E0599`.
2019-09-21T20:34:21.2424570Z 
2019-09-21T20:34:21.2424570Z 
2019-09-21T20:34:21.2424941Z ------------------------------------------
2019-09-21T20:34:21.2425279Z 
2019-09-21T20:34:21.2425435Z 
2019-09-21T20:34:21.2425986Z ---- [ui] ui-fulldeps/plugin-args-1.rs stdout ----
2019-09-21T20:34:21.2426684Z 
2019-09-21T20:34:21.2427191Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-09-21T20:34:21.2427401Z status: exit code: 1
2019-09-21T20:34:21.2428292Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-1/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-1/auxiliary"
2019-09-21T20:34:21.2429164Z ------------------------------------------
2019-09-21T20:34:21.2429331Z 
2019-09-21T20:34:21.2429722Z ------------------------------------------
2019-09-21T20:34:21.2430058Z stderr:
2019-09-21T20:34:21.2430058Z stderr:
2019-09-21T20:34:21.2430365Z ------------------------------------------
2019-09-21T20:34:21.2430767Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-09-21T20:34:21.2431119Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:39:9
2019-09-21T20:34:21.2431302Z    |
2019-09-21T20:34:21.2431448Z LL |     reg.register_syntax_extension(Symbol::intern("plugin_args"), SyntaxExtension::default(
2019-09-21T20:34:21.2431978Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-09-21T20:34:21.2432226Z error: aborting due to previous error
2019-09-21T20:34:21.2432327Z 
2019-09-21T20:34:21.2432660Z For more information about this error, try `rustc --explain E0599`.
2019-09-21T20:34:21.2432789Z 
2019-09-21T20:34:21.2432789Z 
2019-09-21T20:34:21.2433074Z ------------------------------------------
2019-09-21T20:34:21.2433215Z 
2019-09-21T20:34:21.2433313Z 
2019-09-21T20:34:21.2433605Z ---- [ui] ui-fulldeps/plugin-args-2.rs stdout ----
2019-09-21T20:34:21.2433734Z 
2019-09-21T20:34:21.2434543Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-09-21T20:34:21.2434970Z status: exit code: 1
2019-09-21T20:34:21.2436802Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-2/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-2/auxiliary"
2019-09-21T20:34:21.2437818Z ------------------------------------------
2019-09-21T20:34:21.2438025Z 
2019-09-21T20:34:21.2438391Z ------------------------------------------
2019-09-21T20:34:21.2438603Z stderr:
2019-09-21T20:34:21.2438603Z stderr:
2019-09-21T20:34:21.2438956Z ------------------------------------------
2019-09-21T20:34:21.2439519Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-09-21T20:34:21.2440953Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:39:9
2019-09-21T20:34:21.2442053Z    |
2019-09-21T20:34:21.2442102Z LL |     reg.register_syntax_extension(Symbol::intern("plugin_args"), SyntaxExtension::default(
2019-09-21T20:34:21.2442427Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-09-21T20:34:21.2442631Z error: aborting due to previous error
2019-09-21T20:34:21.2442668Z 
2019-09-21T20:34:21.2442918Z For more information about this error, try `rustc --explain E0599`.
2019-09-21T20:34:21.2442946Z 
2019-09-21T20:34:21.2442946Z 
2019-09-21T20:34:21.2443121Z ------------------------------------------
2019-09-21T20:34:21.2443146Z 
2019-09-21T20:34:21.2443166Z 
2019-09-21T20:34:21.2443367Z ---- [ui] ui-fulldeps/plugin-args-3.rs stdout ----
2019-09-21T20:34:21.2443394Z 
2019-09-21T20:34:21.2443611Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-09-21T20:34:21.2443754Z status: exit code: 1
2019-09-21T20:34:21.2444378Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-3/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-3/auxiliary"
2019-09-21T20:34:21.2444650Z ------------------------------------------
2019-09-21T20:34:21.2444676Z 
2019-09-21T20:34:21.2444871Z ------------------------------------------
2019-09-21T20:34:21.2444908Z stderr:
2019-09-21T20:34:21.2444908Z stderr:
2019-09-21T20:34:21.2445082Z ------------------------------------------
2019-09-21T20:34:21.2445346Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-09-21T20:34:21.2445618Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:39:9
2019-09-21T20:34:21.2445659Z    |
2019-09-21T20:34:21.2445715Z LL |     reg.register_syntax_extension(Symbol::intern("plugin_args"), SyntaxExtension::default(
2019-09-21T20:34:21.2446528Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-09-21T20:34:21.2446620Z error: aborting due to previous error
2019-09-21T20:34:21.2446668Z 
2019-09-21T20:34:21.2446954Z For more information about this error, try `rustc --explain E0599`.
2019-09-21T20:34:21.2446989Z 
2019-09-21T20:34:21.2446989Z 
2019-09-21T20:34:21.2447207Z ------------------------------------------
2019-09-21T20:34:21.2447257Z 
2019-09-21T20:34:21.2447283Z 
2019-09-21T20:34:21.2447518Z ---- [ui] ui-fulldeps/plugin-as-extern-crate.rs stdout ----
2019-09-21T20:34:21.2447561Z 
2019-09-21T20:34:21.2447858Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-09-21T20:34:21.2447911Z status: exit code: 1
2019-09-21T20:34:21.2448691Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-as-extern-crate/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-as-extern-crate/auxiliary"
2019-09-21T20:34:21.2449035Z ------------------------------------------
2019-09-21T20:34:21.2449097Z 
2019-09-21T20:34:21.2449322Z ------------------------------------------
2019-09-21T20:34:21.2449367Z stderr:
2019-09-21T20:34:21.2449367Z stderr:
2019-09-21T20:34:21.2449751Z ------------------------------------------
2019-09-21T20:34:21.2450035Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-09-21T20:34:21.2450429Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:19:9
2019-09-21T20:34:21.2450591Z    |
2019-09-21T20:34:21.2450638Z LL |     reg.register_syntax_extension(
2019-09-21T20:34:21.2451137Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-09-21T20:34:21.2451227Z error: aborting due to previous error
2019-09-21T20:34:21.2451253Z 
2019-09-21T20:34:21.2451469Z For more information about this error, try `rustc --explain E0599`.
2019-09-21T20:34:21.2451499Z 
2019-09-21T20:34:21.2451499Z 
2019-09-21T20:34:21.2451705Z ------------------------------------------
2019-09-21T20:34:21.2451810Z 
2019-09-21T20:34:21.2451832Z 
2019-09-21T20:34:21.2452235Z ---- [ui] ui-fulldeps/plugin-attr-register-deny.rs stdout ----
2019-09-21T20:34:21.2452284Z 
2019-09-21T20:34:21.2452536Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-09-21T20:34:21.2452584Z status: exit code: 1
2019-09-21T20:34:21.2453448Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/auxiliary"
2019-09-21T20:34:21.2453912Z ------------------------------------------
2019-09-21T20:34:21.2453939Z 
2019-09-21T20:34:21.2454125Z ------------------------------------------
2019-09-21T20:34:21.2454163Z stderr:
2019-09-21T20:34:21.2454163Z stderr:
2019-09-21T20:34:21.2454539Z ------------------------------------------
2019-09-21T20:34:21.2454981Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-09-21T20:34:21.2455205Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:19:9
2019-09-21T20:34:21.2455265Z    |
2019-09-21T20:34:21.2455483Z LL |     reg.register_syntax_extension(
2019-09-21T20:34:21.2455734Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-09-21T20:34:21.2455992Z error: aborting due to previous error
2019-09-21T20:34:21.2456018Z 
2019-09-21T20:34:21.2457008Z For more information about this error, try `rustc --explain E0599`.
2019-09-21T20:34:21.2457078Z 
2019-09-21T20:34:21.2457078Z 
2019-09-21T20:34:21.2457304Z ------------------------------------------
2019-09-21T20:34:21.2457335Z 
2019-09-21T20:34:21.2457361Z 
2019-09-21T20:34:21.2457604Z ---- [ui] ui-fulldeps/plugin-reexport.rs stdout ----
2019-09-21T20:34:21.2457637Z 
2019-09-21T20:34:21.2457919Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-09-21T20:34:21.2457980Z status: exit code: 1
2019-09-21T20:34:21.2458754Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-reexport/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-reexport/auxiliary"
2019-09-21T20:34:21.2459096Z ------------------------------------------
2019-09-21T20:34:21.2459129Z 
2019-09-21T20:34:21.2459351Z ------------------------------------------
2019-09-21T20:34:21.2459412Z stderr:
2019-09-21T20:34:21.2459412Z stderr:
2019-09-21T20:34:21.2459628Z ------------------------------------------
2019-09-21T20:34:21.2460208Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-09-21T20:34:21.2460682Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:19:9
2019-09-21T20:34:21.2460722Z    |
2019-09-21T20:34:21.2460755Z LL |     reg.register_syntax_extension(
2019-09-21T20:34:21.2461004Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-09-21T20:34:21.2461246Z error: aborting due to previous error
2019-09-21T20:34:21.2461345Z 
2019-09-21T20:34:21.2461586Z For more information about this error, try `rustc --explain E0599`.
2019-09-21T20:34:21.2461614Z 
2019-09-21T20:34:21.2461614Z 
2019-09-21T20:34:21.2462190Z ------------------------------------------
2019-09-21T20:34:21.2462218Z 
2019-09-21T20:34:21.2462257Z 
2019-09-21T20:34:21.2462459Z ---- [ui] ui-fulldeps/roman-numerals-macro.rs stdout ----
2019-09-21T20:34:21.2462488Z 
2019-09-21T20:34:21.2462736Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs" failed to compile: 
2019-09-21T20:34:21.2462800Z status: exit code: 1
2019-09-21T20:34:21.2463467Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary"
2019-09-21T20:34:21.2463767Z ------------------------------------------
2019-09-21T20:34:21.2463795Z 
2019-09-21T20:34:21.2464007Z ------------------------------------------
2019-09-21T20:34:21.2464046Z stderr:
2019-09-21T20:34:21.2464046Z stderr:
2019-09-21T20:34:21.2464243Z ------------------------------------------
2019-09-21T20:34:21.2464535Z error[E0599]: no method named `register_macro` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-09-21T20:34:21.2464922Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:67:9
2019-09-21T20:34:21.2464964Z    |
2019-09-21T20:34:21.2465178Z LL |     reg.register_macro("rn", expand_rn);
2019-09-21T20:34:21.2465560Z    |         ^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-09-21T20:34:21.2465645Z error: aborting due to previous error
2019-09-21T20:34:21.2465668Z 
2019-09-21T20:34:21.2466037Z For more information about this error, try `rustc --explain E0599`.
2019-09-21T20:34:21.2466064Z 
---
2019-09-21T20:34:21.2468912Z test result: FAILED. 61 passed; 8 failed; 0 ignored; 0 measured; 0 filtered out
2019-09-21T20:34:21.2468964Z 
2019-09-21T20:34:21.2468990Z 
2019-09-21T20:34:21.2469015Z 
2019-09-21T20:34:21.2470568Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-21T20:34:21.2470833Z 
2019-09-21T20:34:21.2470855Z 
2019-09-21T20:34:21.2470890Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-21T20:34:21.2470946Z Build completed unsuccessfully in 1:10:01
2019-09-21T20:34:21.2470946Z Build completed unsuccessfully in 1:10:01
2019-09-21T20:34:21.2494200Z == clock drift check ==
2019-09-21T20:34:21.2517745Z   local time: Sat Sep 21 20:34:21 UTC 2019
2019-09-21T20:34:21.5318635Z   network time: Sat, 21 Sep 2019 20:34:21 GMT
2019-09-21T20:34:21.5323385Z == end clock drift check ==
2019-09-21T20:34:23.0147529Z ##[error]Bash exited with code '1'.
2019-09-21T20:34:23.0208703Z ##[section]Starting: Checkout
2019-09-21T20:34:23.0210958Z ==============================================================================
2019-09-21T20:34:23.0211026Z Task         : Get sources
2019-09-21T20:34:23.0211068Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

matklad · 2019-09-22T13:55:40Z

Hm, #64675 proposes to remove the whole compiler plugin infrastructure, so I think its best to just wait for that.

Centril · 2019-10-03T05:39:29Z

Seems we are not removing them as soon as I'd like so meanwhile we should remove some stuff. :)

rust-highfive · 2019-10-03T06:56:23Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-03T05:39:31.4986352Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-03T05:39:31.5234916Z ##[command]git config gc.auto 0
2019-10-03T05:39:31.5325413Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-03T05:39:31.5384852Z ##[command]git config --get-all http.proxy
2019-10-03T05:39:31.5540066Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64665/merge:refs/remotes/pull/64665/merge
---
2019-10-03T06:42:56.4834008Z .................................................................................................... 1500/9092
2019-10-03T06:43:03.4560930Z .................................................................................................... 1600/9092
2019-10-03T06:43:13.2369151Z .................................................................................................... 1700/9092
2019-10-03T06:43:22.1957652Z ...i...............i................................................................................ 1800/9092
2019-10-03T06:43:29.4818577Z ..............................................................................................iiiii. 1900/9092
2019-10-03T06:43:52.6856056Z .................................................................................................... 2100/9092
2019-10-03T06:43:55.2197230Z .................................................................................................... 2200/9092
2019-10-03T06:43:57.9017734Z .................................................................................................... 2300/9092
2019-10-03T06:44:04.4653664Z .................................................................................................... 2400/9092
---
2019-10-03T06:47:06.8702960Z .................................................................................i...............i.. 4700/9092
2019-10-03T06:47:15.3506169Z .................................................................................................... 4800/9092
2019-10-03T06:47:25.9391317Z .................................................................................................... 4900/9092
2019-10-03T06:47:32.0833834Z .................................................................................................... 5000/9092
2019-10-03T06:47:43.7573011Z .........................................................................ii.ii...................... 5100/9092
2019-10-03T06:47:53.6714248Z .................................................................................................... 5300/9092
2019-10-03T06:48:03.6671039Z .................................................................................................... 5400/9092
2019-10-03T06:48:11.1335207Z .......................................i............................................................ 5500/9092
2019-10-03T06:48:17.6819648Z .................................................................................................... 5600/9092
2019-10-03T06:48:17.6819648Z .................................................................................................... 5600/9092
2019-10-03T06:48:28.9777709Z .................................................................................................... 5700/9092
2019-10-03T06:48:40.2742696Z ....................................ii...i..ii............i......................................... 5800/9092
2019-10-03T06:49:03.1445331Z .................................................................................................... 6000/9092
2019-10-03T06:49:12.6873974Z .................................................................................................... 6100/9092
2019-10-03T06:49:12.6873974Z .................................................................................................... 6100/9092
2019-10-03T06:49:26.5919787Z .......................................i..ii........................................................ 6200/9092
2019-10-03T06:49:48.2846075Z ...................................................................................................i 6400/9092
2019-10-03T06:49:50.5636317Z .................................................................................................... 6500/9092
2019-10-03T06:49:52.8921531Z .......................................................................i............................ 6600/9092
2019-10-03T06:49:56.0092367Z .................................................................................................... 6700/9092
---
2019-10-03T06:54:36.3206653Z  finished in 5.587
2019-10-03T06:54:36.3426969Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-03T06:54:36.5174059Z 
2019-10-03T06:54:36.5174388Z running 150 tests
2019-10-03T06:54:39.8934018Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-10-03T06:54:41.9101029Z ..iiii..............i.........iii.i.......ii......
2019-10-03T06:54:41.9101646Z 
2019-10-03T06:54:41.9106954Z  finished in 5.569
2019-10-03T06:54:41.9295501Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-03T06:54:42.0894954Z 
---
2019-10-03T06:54:44.2368783Z  finished in 2.307
2019-10-03T06:54:44.2564738Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-03T06:54:44.4192411Z 
2019-10-03T06:54:44.4192956Z running 9 tests
2019-10-03T06:54:44.4193792Z iiiiiiiii
2019-10-03T06:54:44.4194110Z 
2019-10-03T06:54:44.4194148Z  finished in 0.162
2019-10-03T06:54:44.4402342Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-03T06:54:44.6079952Z 
---
2019-10-03T06:55:03.2194166Z  finished in 18.779
2019-10-03T06:55:03.2413604Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-03T06:55:03.4180341Z 
2019-10-03T06:55:03.4180618Z running 123 tests
2019-10-03T06:55:27.8594169Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-03T06:55:32.6360836Z i.i.i......iii.i.....ii
2019-10-03T06:55:32.6362908Z 
2019-10-03T06:55:32.6364657Z  finished in 29.395
2019-10-03T06:55:32.6376934Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-03T06:55:32.6377590Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-03T06:56:16.8646009Z failures:
2019-10-03T06:56:16.8646654Z 
2019-10-03T06:56:16.8663498Z thread 'main' panicked at 'Some tests failed---- [ui] ui-fulldeps/gated-plugin.rs stdout ----
2019-10-03T06:56:16.8667880Z 
2019-10-03T06:56:16.8669071Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-03T06:56:16.8669592Z status: exit code: 1
2019-10-03T06:56:16.8671113Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary"
2019-10-03T06:56:16.8672041Z ------------------------------------------
2019-10-03T06:56:16.8672988Z 
2019-10-03T06:56:16.8673545Z ------------------------------------------
2019-10-03T06:56:16.8674435Z stderr:
2019-10-03T06:56:16.8674435Z stderr:
2019-10-03T06:56:16.8675302Z ------------------------------------------
2019-10-03T06:56:16.8676070Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-10-03T06:56:16.8676625Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:19:9
2019-10-03T06:56:16.8676903Z    |
2019-10-03T06:56:16.8677125Z LL |     reg.register_syntax_extension(
2019-10-03T06:56:16.8682538Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-10-03T06:56:16.8682899Z error: aborting due to previous error
2019-10-03T06:56:16.8682943Z 
2019-10-03T06:56:16.8685409Z For more information about this error, try `rustc --explain E0599`.
2019-10-03T06:56:16.8686038Z 
2019-10-03T06:56:16.8686038Z 
2019-10-03T06:56:16.8686516Z ------------------------------------------
2019-10-03T06:56:16.8686687Z 
2019-10-03T06:56:16.8686809Z 
2019-10-03T06:56:16.8687187Z ---- [ui] ui-fulldeps/plugin-args-1.rs stdout ----
2019-10-03T06:56:16.8687347Z 
2019-10-03T06:56:16.8687959Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-10-03T06:56:16.8688144Z status: exit code: 1
2019-10-03T06:56:16.8689009Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-1/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-1/auxiliary"
2019-10-03T06:56:16.8689622Z ------------------------------------------
2019-10-03T06:56:16.8689795Z 
2019-10-03T06:56:16.8690641Z ------------------------------------------
2019-10-03T06:56:16.8690852Z stderr:
2019-10-03T06:56:16.8690852Z stderr:
2019-10-03T06:56:16.8691220Z ------------------------------------------
2019-10-03T06:56:16.8691788Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-10-03T06:56:16.8692243Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:39:9
2019-10-03T06:56:16.8692444Z    |
2019-10-03T06:56:16.8692609Z LL |     reg.register_syntax_extension(Symbol::intern("plugin_args"), SyntaxExtension::default(
2019-10-03T06:56:16.8693077Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-10-03T06:56:16.8693745Z error: aborting due to previous error
2019-10-03T06:56:16.8693859Z 
2019-10-03T06:56:16.8694205Z For more information about this error, try `rustc --explain E0599`.
2019-10-03T06:56:16.8694357Z 
2019-10-03T06:56:16.8694357Z 
2019-10-03T06:56:16.8694676Z ------------------------------------------
2019-10-03T06:56:16.8694820Z 
2019-10-03T06:56:16.8694952Z 
2019-10-03T06:56:16.8695299Z ---- [ui] ui-fulldeps/plugin-args-2.rs stdout ----
2019-10-03T06:56:16.8695444Z 
2019-10-03T06:56:16.8695817Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-10-03T06:56:16.8695984Z status: exit code: 1
2019-10-03T06:56:16.8696779Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-2/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-2/auxiliary"
2019-10-03T06:56:16.8697383Z ------------------------------------------
2019-10-03T06:56:16.8697528Z 
2019-10-03T06:56:16.8697861Z ------------------------------------------
2019-10-03T06:56:16.8698199Z stderr:
2019-10-03T06:56:16.8698199Z stderr:
2019-10-03T06:56:16.8698528Z ------------------------------------------
2019-10-03T06:56:16.8699007Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-10-03T06:56:16.8699621Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:39:9
2019-10-03T06:56:16.8699816Z    |
2019-10-03T06:56:16.8700829Z LL |     reg.register_syntax_extension(Symbol::intern("plugin_args"), SyntaxExtension::default(
2019-10-03T06:56:16.8701409Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-10-03T06:56:16.8701753Z error: aborting due to previous error
2019-10-03T06:56:16.8701877Z 
2019-10-03T06:56:16.8702294Z For more information about this error, try `rustc --explain E0599`.
2019-10-03T06:56:16.8702464Z 
2019-10-03T06:56:16.8702464Z 
2019-10-03T06:56:16.8702829Z ------------------------------------------
2019-10-03T06:56:16.8702994Z 
2019-10-03T06:56:16.8703119Z 
2019-10-03T06:56:16.8703671Z ---- [ui] ui-fulldeps/plugin-args-3.rs stdout ----
2019-10-03T06:56:16.8703843Z 
2019-10-03T06:56:16.8704230Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-10-03T06:56:16.8704417Z status: exit code: 1
2019-10-03T06:56:16.8705258Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-3/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-3/auxiliary"
2019-10-03T06:56:16.8705810Z ------------------------------------------
2019-10-03T06:56:16.8705981Z 
2019-10-03T06:56:16.8706307Z ------------------------------------------
2019-10-03T06:56:16.8706474Z stderr:
2019-10-03T06:56:16.8706474Z stderr:
2019-10-03T06:56:16.8706822Z ------------------------------------------
2019-10-03T06:56:16.8707470Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-10-03T06:56:16.8707872Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:39:9
2019-10-03T06:56:16.8708042Z    |
2019-10-03T06:56:16.8708184Z LL |     reg.register_syntax_extension(Symbol::intern("plugin_args"), SyntaxExtension::default(
2019-10-03T06:56:16.8708585Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-10-03T06:56:16.8708885Z error: aborting due to previous error
2019-10-03T06:56:16.8708995Z 
2019-10-03T06:56:16.8709337Z For more information about this error, try `rustc --explain E0599`.
2019-10-03T06:56:16.8709505Z 
2019-10-03T06:56:16.8709505Z 
2019-10-03T06:56:16.8709843Z ------------------------------------------
2019-10-03T06:56:16.8710389Z 
2019-10-03T06:56:16.8710520Z 
2019-10-03T06:56:16.8710932Z ---- [ui] ui-fulldeps/plugin-as-extern-crate.rs stdout ----
2019-10-03T06:56:16.8711126Z 
2019-10-03T06:56:16.8711589Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-03T06:56:16.8711796Z status: exit code: 1
2019-10-03T06:56:16.8712995Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-as-extern-crate/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-as-extern-crate/auxiliary"
2019-10-03T06:56:16.8713861Z ------------------------------------------
2019-10-03T06:56:16.8714179Z 
2019-10-03T06:56:16.8714532Z ------------------------------------------
2019-10-03T06:56:16.8714918Z stderr:
2019-10-03T06:56:16.8714918Z stderr:
2019-10-03T06:56:16.8715265Z ------------------------------------------
2019-10-03T06:56:16.8715838Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-10-03T06:56:16.8716308Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:19:9
2019-10-03T06:56:16.8716510Z    |
2019-10-03T06:56:16.8716655Z LL |     reg.register_syntax_extension(
2019-10-03T06:56:16.8717050Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-10-03T06:56:16.8717368Z error: aborting due to previous error
2019-10-03T06:56:16.8717481Z 
2019-10-03T06:56:16.8718007Z For more information about this error, try `rustc --explain E0599`.
2019-10-03T06:56:16.8718180Z 
2019-10-03T06:56:16.8718180Z 
2019-10-03T06:56:16.8718526Z ------------------------------------------
2019-10-03T06:56:16.8718687Z 
2019-10-03T06:56:16.8718799Z 
2019-10-03T06:56:16.8719135Z ---- [ui] ui-fulldeps/plugin-attr-register-deny.rs stdout ----
2019-10-03T06:56:16.8719280Z 
2019-10-03T06:56:16.8719663Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-03T06:56:16.8720551Z status: exit code: 1
2019-10-03T06:56:16.8721757Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/auxiliary"
2019-10-03T06:56:16.8722405Z ------------------------------------------
2019-10-03T06:56:16.8722571Z 
2019-10-03T06:56:16.8723002Z ------------------------------------------
2019-10-03T06:56:16.8723202Z stderr:
2019-10-03T06:56:16.8723202Z stderr:
2019-10-03T06:56:16.8723729Z ------------------------------------------
2019-10-03T06:56:16.8724183Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-10-03T06:56:16.8724600Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:19:9
2019-10-03T06:56:16.8724990Z    |
2019-10-03T06:56:16.8725142Z LL |     reg.register_syntax_extension(
2019-10-03T06:56:16.8730779Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-10-03T06:56:16.8731282Z error: aborting due to previous error
2019-10-03T06:56:16.8739587Z 
2019-10-03T06:56:16.8744126Z For more information about this error, try `rustc --explain E0599`.
2019-10-03T06:56:16.8744371Z 
2019-10-03T06:56:16.8744371Z 
2019-10-03T06:56:16.8744650Z ------------------------------------------
2019-10-03T06:56:16.8744682Z 
2019-10-03T06:56:16.8744705Z 
2019-10-03T06:56:16.8745129Z ---- [ui] ui-fulldeps/plugin-reexport.rs stdout ----
2019-10-03T06:56:16.8745162Z 
2019-10-03T06:56:16.8745447Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-03T06:56:16.8745503Z status: exit code: 1
2019-10-03T06:56:16.8746234Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-reexport/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-reexport/auxiliary"
2019-10-03T06:56:16.8746990Z ------------------------------------------
2019-10-03T06:56:16.8747131Z 
2019-10-03T06:56:16.8747543Z ------------------------------------------
2019-10-03T06:56:16.8747588Z stderr:
2019-10-03T06:56:16.8747588Z stderr:
2019-10-03T06:56:16.8747811Z ------------------------------------------
2019-10-03T06:56:16.8748117Z error[E0599]: no method named `register_syntax_extension` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-10-03T06:56:16.8748368Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:19:9
2019-10-03T06:56:16.8748435Z    |
2019-10-03T06:56:16.8748637Z LL |     reg.register_syntax_extension(
2019-10-03T06:56:16.8749054Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-10-03T06:56:16.8749152Z error: aborting due to previous error
2019-10-03T06:56:16.8749178Z 
2019-10-03T06:56:16.8749393Z For more information about this error, try `rustc --explain E0599`.
2019-10-03T06:56:16.8749440Z 
2019-10-03T06:56:16.8749440Z 
2019-10-03T06:56:16.8749637Z ------------------------------------------
2019-10-03T06:56:16.8749667Z 
2019-10-03T06:56:16.8749689Z 
2019-10-03T06:56:16.8750302Z ---- [ui] ui-fulldeps/roman-numerals-macro.rs stdout ----
2019-10-03T06:56:16.8750342Z 
2019-10-03T06:56:16.8750654Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs" failed to compile: 
2019-10-03T06:56:16.8750708Z status: exit code: 1
2019-10-03T06:56:16.8751507Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary"
2019-10-03T06:56:16.8751851Z ------------------------------------------
2019-10-03T06:56:16.8751885Z 
2019-10-03T06:56:16.8752104Z ------------------------------------------
2019-10-03T06:56:16.8752167Z stderr:
2019-10-03T06:56:16.8752167Z stderr:
2019-10-03T06:56:16.8752383Z ------------------------------------------
2019-10-03T06:56:16.8753110Z error[E0599]: no method named `register_macro` found for type `&mut rustc_driver::rustc_plugin_impl::Registry<'_>` in the current scope
2019-10-03T06:56:16.8753413Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:67:9
2019-10-03T06:56:16.8753631Z    |
2019-10-03T06:56:16.8753677Z LL |     reg.register_macro("rn", expand_rn);
2019-10-03T06:56:16.8753946Z    |         ^^^^^^^^^^^^^^ method not found in `&mut rustc_driver::rustc_plugin_impl::Registry<'_>`
2019-10-03T06:56:16.8754029Z error: aborting due to previous error
2019-10-03T06:56:16.8754056Z 
2019-10-03T06:56:16.8754302Z For more information about this error, try `rustc --explain E0599`.
2019-10-03T06:56:16.8754334Z 
---
2019-10-03T06:56:16.8757260Z ', src/tools/compiletest/src/main.rs:537:22
2019-10-03T06:56:16.8757322Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-10-03T06:56:16.8757353Z 
2019-10-03T06:56:16.8757377Z 
2019-10-03T06:56:16.8759288Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-10-03T06:56:16.8759519Z 
2019-10-03T06:56:16.8759546Z 
2019-10-03T06:56:16.8759607Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-03T06:56:16.8759660Z Build completed unsuccessfully in 1:09:33
2019-10-03T06:56:16.8759660Z Build completed unsuccessfully in 1:09:33
2019-10-03T06:56:16.8759703Z == clock drift check ==
2019-10-03T06:56:16.8770647Z   local time: Thu Oct  3 06:56:16 UTC 2019
2019-10-03T06:56:17.0572967Z   network time: Thu, 03 Oct 2019 06:56:17 GMT
2019-10-03T06:56:17.0575450Z == end clock drift check ==
2019-10-03T06:56:18.5095395Z ##[error]Bash exited with code '1'.
2019-10-03T06:56:18.5164729Z ##[section]Starting: Checkout
2019-10-03T06:56:18.5166542Z ==============================================================================
2019-10-03T06:56:18.5166616Z Task         : Get sources
2019-10-03T06:56:18.5166661Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

JohnTitor · 2019-10-13T09:04:56Z

Ping from triage: @matklad any updates on this?

bors · 2019-10-17T22:41:19Z

☔ The latest upstream changes (presumably #65495) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum · 2019-10-24T00:37:22Z

@matklad visiting for triage -- this would be good to rebase and land, I think.

Ideally we'd entirely remove syntactic extension plugins -- I believe all or almost all use cases are replaceable via proc macro today (though possibly in an unstable way, but plugins are unstable anyway) -- so we should be able to make that move. Servo, Clippy, etc. don't appear to use it.

joelpalmer · 2019-10-28T13:27:44Z

Ping from triage: @matklad any updates on this?

matklad · 2019-10-31T07:57:50Z

Heh, I think empirical evidence shows that I am swamped with rust-analyzer task at the moment :(

Let's close this for now: I plan to get back to this, but I can't give any ETA at the moment.

remove compiler plugin API for syntax transformers

20338a4

This role is full filled by proc-macros now

rust-highfive assigned cramertj Sep 21, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2019

rust-highfive assigned petrochenkov and unassigned cramertj Sep 21, 2019

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2019

matklad closed this Sep 22, 2019

Centril reopened this Oct 3, 2019

matklad closed this Oct 31, 2019

petrochenkov mentioned this pull request Nov 22, 2019

rustc_plugin: Remove support for syntactic plugins #66647

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: remove compiler plugin API for syntax transformers #64665

WIP: remove compiler plugin API for syntax transformers #64665

matklad commented Sep 21, 2019 •

edited

Loading

rust-highfive commented Sep 21, 2019

matklad commented Sep 21, 2019

petrochenkov commented Sep 21, 2019

matklad commented Sep 21, 2019

petrochenkov commented Sep 21, 2019

rust-highfive commented Sep 21, 2019

matklad commented Sep 22, 2019

Centril commented Oct 3, 2019

rust-highfive commented Oct 3, 2019

JohnTitor commented Oct 13, 2019

bors commented Oct 17, 2019

Mark-Simulacrum commented Oct 24, 2019

joelpalmer commented Oct 28, 2019

matklad commented Oct 31, 2019

WIP: remove compiler plugin API for syntax transformers #64665

WIP: remove compiler plugin API for syntax transformers #64665

Conversation

matklad commented Sep 21, 2019 • edited Loading

rust-highfive commented Sep 21, 2019

matklad commented Sep 21, 2019

petrochenkov commented Sep 21, 2019

matklad commented Sep 21, 2019

petrochenkov commented Sep 21, 2019

rust-highfive commented Sep 21, 2019

matklad commented Sep 22, 2019

Centril commented Oct 3, 2019

rust-highfive commented Oct 3, 2019

JohnTitor commented Oct 13, 2019

bors commented Oct 17, 2019

Mark-Simulacrum commented Oct 24, 2019

joelpalmer commented Oct 28, 2019

matklad commented Oct 31, 2019

matklad commented Sep 21, 2019 •

edited

Loading