-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement FromIterator<char> for Box<str> #65168
Closed
Closed
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c481236
implement FromIterator<char> for Box<str>
a0a313c
fixed trailing newline
7192b0c
added use crate::string::String
b268827
added use std::string::String
ab689ea
Using String::from_iter
048710a
fixed test
0fad2a6
fixed unused import
c73c4b4
changed string.len() into string.chars().count()
f2f9eec
Making the implementation stable
Duddino b10277a
since 1.40.0
Duddino e773b20
removed issue
Duddino 4ddbf8d
removed whitespaces
Duddino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -151,3 +151,12 @@ fn test_array_from_slice() { | |
let a: Result<Box<[u32; 2]>, _> = r.clone().try_into(); | ||
assert!(a.is_err()); | ||
} | ||
|
||
#[test] | ||
fn box_str_from_iter(){ | ||
let iter = (0..100).map(|_|{'☺'}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ☺ |
||
let string: Box<str> = iter.collect(); | ||
|
||
assert_eq!(string.chars().count(), 100); | ||
assert_eq!(string.chars().nth(5), Some('☺')); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
impls are going to be insta-stable, you can probably make this just be stable with the same feature name