-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #68625
Merged
Merged
Rollup of 8 pull requests #68625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generate links to the primitive type docs for re-exports. * Don't ICE on cross crate primitive type re-exports. * Make primitive type re-exports show up cross crate.
So, instead of ICE'ing, just fail to mark green in such cases (for `DepKind::{Hir, HirBody, CrateMetadata}`). Fix rust-lang#62649.
Mainly for API parity with HashMap. - Add BTreeMap::remove_entry - Rewrite BTreeMap::remove to use remove_entry - Use btreemap_remove_entry feature in doc comment
Since the docs for the WASI API are now evolving in [WebAssembly/WASI] repo, I thought it might be useful to update the links in the docs to point to that location instead of using the outdated `CraneStation/wasmtime` destination. [WebAssembly/WASI]: https://github.com/WebAssembly/WASI
…th-collision-in-dep-graph, r=michaelwoerister Don't ICE on path-collision in dep-graph Collisions in the dep-graph due to path-reuse are rare but can occur. So, instead of ICE'ing, just fail to mark green in such cases (for `DepKind::{Hir, HirBody, CrateMetadata}`). Fix rust-lang#62649.
…r=KodrAus Add BTreeMap::remove_entry Implements rust-lang#66714.
…l-pos, r=kinnison Fix run button positionning in case of scrolling Fixes rust-lang#68337. r? @kinnison
…, r=GuillaumeGomez rustdoc: Fix re-exporting primitive types * Generate links to the primitive type docs for re-exports. * Don't ICE on cross crate primitive type re-exports. * Make primitive type re-exports show up cross crate. Fixes rust-lang#67646 Closes rust-lang#67972 r? @GuillaumeGomez
…r=Dylan-DPC Add E0727 long explanation Add long explanation for the `E0727` error code (async generators not yet supported). Part of rust-lang#61137 r? @GuillaumeGomez
fix: typo in vec.rs
Fix a few spelling mistakes
Update links to WASI docs in time.rs module Since the docs for the WASI API are now evolving in [WebAssembly/WASI] repo, I thought it might be useful to update the links in the docs to point to that location instead of using the outdated `CraneStation/wasmtime` destination. [WebAssembly/WASI]: https://github.com/WebAssembly/WASI r? @steveklabnik cc @alexcrichton
@bors r+ p=8 rollup=never |
📌 Commit c0df1be has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 29, 2020
bors
added a commit
that referenced
this pull request
Jan 29, 2020
Rollup of 8 pull requests Successful merges: - #68289 (Don't ICE on path-collision in dep-graph) - #68378 (Add BTreeMap::remove_entry) - #68553 (Fix run button positionning in case of scrolling) - #68556 (rustdoc: Fix re-exporting primitive types) - #68582 (Add E0727 long explanation) - #68592 (fix: typo in vec.rs) - #68619 (Fix a few spelling mistakes) - #68620 (Update links to WASI docs in time.rs module) Failed merges: r? @ghost
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost