Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clippy #68998

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Update clippy #68998

merged 1 commit into from
Feb 12, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Feb 9, 2020

Closes #68901

@tesuji
Copy link
Contributor Author

tesuji commented Feb 9, 2020

Let's wait for CI before r+
r? @Manishearth

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2020
@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Contributor

bors commented Feb 9, 2020

📌 Commit dd2b0a15d0f2a03271e159ac40596f6dc6e88345 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2020
@Dylan-DPC-zz
Copy link

@bors rollup=never p=1

@bors
Copy link
Contributor

bors commented Feb 11, 2020

⌛ Testing commit dd2b0a15d0f2a03271e159ac40596f6dc6e88345 with merge 7dbd01005b8555984d99174d5dbf299c86532141...

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-11T12:40:12.1762407Z    Compiling rustbook v0.1.0 (/checkout/src/tools/rustbook)
2020-02-11T12:40:18.2947592Z [RUSTC-TIMING] rustbook test:false 6.112
2020-02-11T12:40:18.3014574Z     Finished release [optimized] target(s) in 12m 36s
2020-02-11T12:40:18.3241692Z [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "rustbook", path: "src/tools/rustbook", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: ["linkcheck"] } -- 756.091
2020-02-11T12:42:05.3394697Z Unsuccessful server response for link `https://ieeexplore.ieee.org/document/6650903`
2020-02-11T12:42:05.3423893Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-11T12:42:05.3424597Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2020-02-11T12:42:05.3611596Z Building stage2 tool clippy-driver (x86_64-unknown-linux-gnu)
2020-02-11T12:42:05.6455708Z    Compiling proc-macro2 v0.4.30
---
2020-02-11T13:06:28.5210495Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2020-02-11T13:06:28.5210552Z 
2020-02-11T13:06:28.5210990Z We detected that this PR updated 'clippy-driver', but its tests failed.
2020-02-11T13:06:28.5211096Z 
2020-02-11T13:06:28.5211374Z If you do intend to update 'clippy-driver', please check the error messages above and
2020-02-11T13:06:28.5211451Z commit another update.
2020-02-11T13:06:28.5211518Z 
2020-02-11T13:06:28.5211755Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2020-02-11T13:06:28.5212018Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2020-02-11T13:06:28.5212089Z proper steps.
2020-02-11T13:06:28.5220993Z Build completed unsuccessfully in 0:00:01
2020-02-11T13:06:28.5271661Z == clock drift check ==
2020-02-11T13:06:28.5289122Z   local time: Tue Feb 11 13:06:28 UTC 2020
2020-02-11T13:06:28.5787128Z   network time: Tue, 11 Feb 2020 13:06:28 GMT
2020-02-11T13:06:28.5787128Z   network time: Tue, 11 Feb 2020 13:06:28 GMT
2020-02-11T13:06:28.5791224Z == end clock drift check ==
2020-02-11T13:06:29.0780028Z 
2020-02-11T13:06:29.0876574Z ##[error]Bash exited with code '1'.
2020-02-11T13:06:29.0921697Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-11T13:06:29.0923530Z ==============================================================================
2020-02-11T13:06:29.0923774Z Task         : Get sources
2020-02-11T13:06:29.0923845Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Feb 11, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Feb 11, 2020

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Feb 11, 2020

Included rust-lang/rust-clippy#5150

@Manishearth
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Feb 11, 2020

📌 Commit 02be293aa6a9861983b5207d0749f1be7261fb93 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Feb 11, 2020

@bors r-
It would fail if Invert control in struct_lint_level pr merged.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Feb 12, 2020

Included rust-lang/rust-clippy#5152

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2020

📌 Commit 1db0a22 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2020
@bors
Copy link
Contributor

bors commented Feb 12, 2020

⌛ Testing commit 1db0a22 with merge 7cba853...

bors added a commit that referenced this pull request Feb 12, 2020
@bors
Copy link
Contributor

bors commented Feb 12, 2020

☀️ Test successful - checks-azure
Approved by: Manishearth
Pushing 7cba853 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 12, 2020
@bors bors merged commit 1db0a22 into rust-lang:master Feb 12, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #68998!

Tested on commit 7cba853.
Direct link to PR: #68998

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 12, 2020
Tested on commit rust-lang/rust@7cba853.
Direct link to PR: <rust-lang/rust#68998>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
@tesuji tesuji deleted the clippyup branch February 12, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#68893
6 participants